Bug 90087 – [CSS Filters] Blur filter is not repainted correctly when applied on a parent of a fixed element

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Alexandru Chiculita]

This bug is a follow up of the review on https://bugs.webkit.org/show_bug.cgi?id=89475 . 

That bug fixed the case when the blur is applied on the first parent layer of a fixed element, but we need to check all the ancestors.

The case when that happens is for example when there is a sepia layer applied on the first parent and a blur on the second parent.

[Alexandru Chiculita]

It should also check whether the fixed element itself has a blur filter.

[Alexandru Chiculita]

Created attachment 149831 [details]
Patch V1

[Simon Fraser (smfr)]

Comment on attachment 149831 [details]
Patch V1

View in context: https://bugs.webkit.org/attachment.cgi?id=149831&action=review

> Source/WebCore/page/FrameView.cpp:1466
> +        if (renderBox->layer() && renderBox->layer()->hasParentWithFilterOutsets()) {

This could be a little slow because it has to run up the tree every time. Maybe we should add a 'hasFilteredAncestor' bit somewhere in future.

[Simon Fraser (smfr)]

Comment on attachment 149831 [details]
Patch V1

View in context: https://bugs.webkit.org/attachment.cgi?id=149831&action=review

> Source/WebCore/rendering/RenderLayer.cpp:1092
> +bool RenderLayer::hasParentWithFilterOutsets() const

This name is confusing; it's hasAncestorWithFilterOutsets.

[Alexandru Chiculita]

Created attachment 150231 [details]
Patch for commit

Thanks for the review. I've updated and posted for commit-queue.

[WebKit Review Bot]

Comment on attachment 150231 [details]
Patch for commit

Attachment 150231 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13110510

New failing tests:
fast/repaint/block-selection-gap-in-composited-layer.html

[WebKit Review Bot]

Created attachment 150262 [details]
Archive of layout-test-results from ec2-cr-linux-04

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-04  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Alexandru Chiculita]

Created attachment 151280 [details]
Patch for commit

[WebKit Review Bot]

Comment on attachment 151280 [details]
Patch for commit

Clearing flags on attachment: 151280

Committed r122130: <http://trac.webkit.org/changeset/122130>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.