Bug 90061 - [WK2] [GTK] WebKit2 testing bot fails to run tests due to missing files
Summary: [WK2] [GTK] WebKit2 testing bot fails to run tests due to missing files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-27 04:30 PDT by Sergio Villar Senin
Modified: 2012-06-27 08:52 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.46 KB, patch)
2012-06-27 06:46 PDT, Sergio Villar Senin
gustavo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2012-06-27 04:30:13 PDT
Currently the WK2 uses a packed build from the 64 bit release bot to run the tests instead of doing the build on its own. The scripts currently pack the Programs/ and .libs/ dirs under the WebKitBuild/Release directory. This is clearly not enough because in the Programs/ dir there are some libtool files that point to object files located under WebKitBuild/Release/Sources/.

So there are several possibilities here:
1- add the WebKitBuild/Release/Source/ directory to the packed build. That's easy to do, but we'll be adding ~30Mb to the compressed file where we pack the build (it's already ~45Mb and takes 10-15 min to be uploaded to the master after each build)

2- somehow tweak our build system to create the executables we want in a Programs/ directory (as our testing tools expect that name) and pack it instead of WebKitBuild/Release/Programs

3- ... any other?
Comment 1 Carlos Garcia Campos 2012-06-27 05:36:28 PDT
Since bots never run make install, we could just build with no install ld flags, like we currently do for noinst programs. That way binaries will be generated for web and plugin process instead of libtool scripts.
Comment 2 Sergio Villar Senin 2012-06-27 06:46:42 PDT
Created attachment 149740 [details]
Patch

Something like this?
Comment 3 Sergio Villar Senin 2012-06-27 08:29:43 PDT
(In reply to comment #2)
> Created an attachment (id=149740) [details]
> Patch
> 
> Something like this?

Carlos suggested also adding -no-fast-install as we do it also right now for noinst programs
Comment 4 Gustavo Noronha (kov) 2012-06-27 08:31:29 PDT
Comment on attachment 149740 [details]
Patch

Looks sane to me.
Comment 5 Sergio Villar Senin 2012-06-27 08:52:16 PDT
Committed r121345: <http://trac.webkit.org/changeset/121345>