NEW 90030
When reviewing patches, render tests and references 
https://bugs.webkit.org/show_bug.cgi?id=90030
Summary When reviewing patches, render tests and references
Simon Fraser (smfr)
Reported 2012-06-26 17:45:02 PDT
When reviewing a patch like https://bugs.webkit.org/attachment.cgi?id=149641&action=review I have a hard time evaluating the test and its reference, because I can't easily see what the test looks like (there's no pixel result). I'd love for the patch reviewing UI to have some way to show the test and reference in iframes, so I can visually inspect them.
Attachments
Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2012-06-26 18:36:52 PDT
Agree this would be nice. Could even do a pixel diff in JS. It's a little tricker in cases where you're modifying an existing reftest, but even in that case, we already have the ability to apply the modification to tip-of-tree to get the full HTML file.
Note You need to log in before you can comment on or make changes to this bug.