Bug 90029 - [Chromium] Remove unused build scripts and empty folders for JavaScriptCore w/ gyp
Summary: [Chromium] Remove unused build scripts and empty folders for JavaScriptCore w...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dominic Cooney
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-26 17:35 PDT by Dominic Cooney
Modified: 2012-06-27 02:44 PDT (History)
2 users (show)

See Also:


Attachments
Patch (5.08 KB, patch)
2012-06-26 17:42 PDT, Dominic Cooney
abarth: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dominic Cooney 2012-06-26 17:35:04 PDT
It seems r119921 (see bug 88510) left Source/WebCore/gyp empty; the folder should be removed. Scripts in Source/JavaScriptCore/gyp appear to be unused and could be removed too.
Comment 1 Dominic Cooney 2012-06-26 17:42:34 PDT
Created attachment 149647 [details]
Patch
Comment 2 Adam Barth 2012-06-26 18:02:15 PDT
Thanks.
Comment 3 WebKit Review Bot 2012-06-26 19:39:18 PDT
Comment on attachment 149647 [details]
Patch

Rejecting attachment 149647 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
riptCore/gyp/update-info-plist.sh,
which does not exist!  Applying it anyway.
patching file Source/JavaScriptCore/gyp/update-info-plist.sh
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file Source/JavaScriptCore/gyp/update-info-plist.sh.rej
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13087733
Comment 4 Dominic Cooney 2012-06-26 19:59:35 PDT
I will land this manually.
Comment 5 Dominic Cooney 2012-06-27 02:44:52 PDT
Committed r121334: <http://trac.webkit.org/changeset/121334>