Bug 90027 - Add support for preciseTime() to WebKitTestRunner
Summary: Add support for preciseTime() to WebKitTestRunner
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-26 17:02 PDT by Mark Hahnenberg
Modified: 2012-06-26 18:38 PDT (History)
2 users (show)

See Also:


Attachments
Patch (3.20 KB, patch)
2012-06-26 17:27 PDT, Mark Hahnenberg
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2012-06-26 17:02:58 PDT
It would be nice to be able to use preciseTime() in WebKitTestRunner like we can in DumpRenderTree.
Comment 1 Mark Hahnenberg 2012-06-26 17:27:23 PDT
Created attachment 149642 [details]
Patch
Comment 2 Darin Adler 2012-06-26 17:58:53 PDT
Comment on attachment 149642 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=149642&action=review

> Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:625
> +    return JSValueMakeNumber(context, WTF::currentTime());

The WTF prefix should not be needed here.

> Tools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:35
> +        object preciseTime();

Don’t we have bindings for double? Why does this have to be done with a general purpose value? Clearly, the terminology is wrong, by the way, because the value will not be an object.
Comment 3 Mark Hahnenberg 2012-06-26 18:38:53 PDT
Committed r121308: <http://trac.webkit.org/changeset/121308>