WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
90027
Add support for preciseTime() to WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=90027
Summary
Add support for preciseTime() to WebKitTestRunner
Mark Hahnenberg
Reported
2012-06-26 17:02:58 PDT
It would be nice to be able to use preciseTime() in WebKitTestRunner like we can in DumpRenderTree.
Attachments
Patch
(3.20 KB, patch)
2012-06-26 17:27 PDT
,
Mark Hahnenberg
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1
2012-06-26 17:27:23 PDT
Created
attachment 149642
[details]
Patch
Darin Adler
Comment 2
2012-06-26 17:58:53 PDT
Comment on
attachment 149642
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=149642&action=review
> Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:625 > + return JSValueMakeNumber(context, WTF::currentTime());
The WTF prefix should not be needed here.
> Tools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:35 > + object preciseTime();
Don’t we have bindings for double? Why does this have to be done with a general purpose value? Clearly, the terminology is wrong, by the way, because the value will not be an object.
Mark Hahnenberg
Comment 3
2012-06-26 18:38:53 PDT
Committed
r121308
: <
http://trac.webkit.org/changeset/121308
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug