WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
90026
DFG PutByValAlias is too aggressive
https://bugs.webkit.org/show_bug.cgi?id=90026
Summary
DFG PutByValAlias is too aggressive
Filip Pizlo
Reported
2012-06-26 16:45:12 PDT
It is often used in places where we can't assume that the previous ByVal op had done a proper array bounds check.
Attachments
the patch
(18.85 KB, patch)
2012-06-26 16:50 PDT
,
Filip Pizlo
barraclough
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Filip Pizlo
Comment 1
2012-06-26 16:45:28 PDT
<
rdar://problem/11751830
>
Filip Pizlo
Comment 2
2012-06-26 16:50:02 PDT
Created
attachment 149631
[details]
the patch
Gavin Barraclough
Comment 3
2012-06-26 16:58:58 PDT
Comment on
attachment 149631
[details]
the patch View in context:
https://bugs.webkit.org/attachment.cgi?id=149631&action=review
If possible please to be adding a test for the regular arrays.
> Source/JavaScriptCore/dfg/DFGGraph.h:480 > + return true;
:-(
Filip Pizlo
Comment 4
2012-06-26 18:34:24 PDT
Landed in
http://trac.webkit.org/changeset/121307
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug