Bug 90026 - DFG PutByValAlias is too aggressive
Summary: DFG PutByValAlias is too aggressive
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-06-26 16:45 PDT by Filip Pizlo
Modified: 2012-06-26 18:34 PDT (History)
0 users

See Also:


Attachments
the patch (18.85 KB, patch)
2012-06-26 16:50 PDT, Filip Pizlo
barraclough: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-06-26 16:45:12 PDT
It is often used in places where we can't assume that the previous ByVal op had done a proper array bounds check.
Comment 1 Filip Pizlo 2012-06-26 16:45:28 PDT
<rdar://problem/11751830>
Comment 2 Filip Pizlo 2012-06-26 16:50:02 PDT
Created attachment 149631 [details]
the patch
Comment 3 Gavin Barraclough 2012-06-26 16:58:58 PDT
Comment on attachment 149631 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=149631&action=review

If possible please to be adding a test for the regular arrays.

> Source/JavaScriptCore/dfg/DFGGraph.h:480
> +            return true;

:-(
Comment 4 Filip Pizlo 2012-06-26 18:34:24 PDT
Landed in http://trac.webkit.org/changeset/121307