Bug 90024 - Convert editing/inserting/font-size-clears-from-typing-style.html to a dump-as-markup test
Summary: Convert editing/inserting/font-size-clears-from-typing-style.html to a dump-a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-26 16:20 PDT by Ryosuke Niwa
Modified: 2012-07-06 22:54 PDT (History)
4 users (show)

See Also:


Attachments
Patch (4.77 KB, patch)
2012-06-26 16:21 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-06-26 16:20:48 PDT
Convert editing/inserting/font-size-clears-from-typing-style.html to a dump-as-markup test
Comment 1 Ryosuke Niwa 2012-06-26 16:21:49 PDT
Created attachment 149625 [details]
Patch
Comment 2 Darin Adler 2012-06-26 16:28:33 PDT
Comment on attachment 149625 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=149625&action=review

> LayoutTests/ChangeLog:8
> +        Converted a script test to a dump-as-markup test because the test result can be understood much eaiser that way.

Unfortunately this test no longer states what the expected result is. That’s a step backwards. Before the test would say PASS or FAIL. Now it just dumps out a tree and you have to know what the expected result is.
Comment 3 Darin Adler 2012-06-26 16:29:09 PDT
For some reason bugzilla caused the patch to change to review? -- I did not intend to change that or remove Ojan’s review+, just add my comments.
Comment 4 Darin Adler 2012-06-26 16:29:36 PDT
Comment on attachment 149625 [details]
Patch

Clearing the review flag. I did not intend to cancel out Ojan’s review+ although I do think there is a missing element to the test now.
Comment 5 Ryosuke Niwa 2012-06-26 16:29:59 PDT
Comment on attachment 149625 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=149625&action=review

>> LayoutTests/ChangeLog:8
>> +        Converted a script test to a dump-as-markup test because the test result can be understood much eaiser that way.
> 
> Unfortunately this test no longer states what the expected result is. That’s a step backwards. Before the test would say PASS or FAIL. Now it just dumps out a tree and you have to know what the expected result is.

Yeah, fixing that by improving the test description now.
Comment 6 Ryosuke Niwa 2012-06-26 16:31:38 PDT
(In reply to comment #4)
> (From update of attachment 149625 [details])
> Clearing the review flag. I did not intend to cancel out Ojan’s review+ although I do think there is a missing element to the test now.

I'm revising the test description to "Tests that we don't serialize redundant font-size in typingStyle. There should be no span or style attribute around A or B below."
Comment 7 Ryosuke Niwa 2012-07-06 22:54:40 PDT
Fixed in http://trac.webkit.org/changeset/121298.