Convert editing/inserting/font-size-clears-from-typing-style.html to a dump-as-markup test
Created attachment 149625 [details] Patch
Comment on attachment 149625 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149625&action=review > LayoutTests/ChangeLog:8 > + Converted a script test to a dump-as-markup test because the test result can be understood much eaiser that way. Unfortunately this test no longer states what the expected result is. That’s a step backwards. Before the test would say PASS or FAIL. Now it just dumps out a tree and you have to know what the expected result is.
For some reason bugzilla caused the patch to change to review? -- I did not intend to change that or remove Ojan’s review+, just add my comments.
Comment on attachment 149625 [details] Patch Clearing the review flag. I did not intend to cancel out Ojan’s review+ although I do think there is a missing element to the test now.
Comment on attachment 149625 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149625&action=review >> LayoutTests/ChangeLog:8 >> + Converted a script test to a dump-as-markup test because the test result can be understood much eaiser that way. > > Unfortunately this test no longer states what the expected result is. That’s a step backwards. Before the test would say PASS or FAIL. Now it just dumps out a tree and you have to know what the expected result is. Yeah, fixing that by improving the test description now.
(In reply to comment #4) > (From update of attachment 149625 [details]) > Clearing the review flag. I did not intend to cancel out Ojan’s review+ although I do think there is a missing element to the test now. I'm revising the test description to "Tests that we don't serialize redundant font-size in typingStyle. There should be no span or style attribute around A or B below."
Fixed in http://trac.webkit.org/changeset/121298.