Skia <canvas> should respect webkitBackingStorePixelRatio. It should scale up the ImageBuffers which are created, and scale up the base transform applied to drawing commands to compensate.
Created attachment 149623 [details] early draft, not for review
Comment on attachment 149623 [details] early draft, not for review Attachment 149623 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13102568 New failing tests: canvas/philip/tests/2d.imageData.get.source.outside.html platform/chromium/virtual/gpu/canvas/philip/tests/2d.imageData.get.source.outside.html
Created attachment 149664 [details] Archive of layout-test-results from ec2-cr-linux-02 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-02 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment on attachment 149623 [details] early draft, not for review Attachment 149623 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13093671 New failing tests: canvas/philip/tests/2d.imageData.get.source.outside.html platform/chromium/virtual/gpu/canvas/philip/tests/2d.imageData.get.source.outside.html
Created attachment 149670 [details] Archive of layout-test-results from ec2-cr-linux-03 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Created attachment 149762 [details] handle premul/unpremul in putImageData(), fix getImageData() clearing tests
Created attachment 149983 [details] Apply scaling in ImageBuffer::draw(), ImageBuffer::drawPattern(), ImageBuffer::toDataURL()
Created attachment 149997 [details] Remove LayoutTestController changes
I've said this before I'm sure, but I'm not a fan of this API and don't think we should be shipping this in Chrome. It's a short-term hack that will stick around in the web platform long after its usefulness has expired.
(In reply to comment #9) > I've said this before I'm sure, but I'm not a fan of this API and don't think we should be shipping this in Chrome. It's a short-term hack that will stick around in the web platform long after its usefulness has expired. Yes, I agree. To be honest, I'd be happier not to land this, if that's the consensus.
Comment on attachment 149997 [details] Remove LayoutTestController changes R- for now, then. (FWIW, the code looks pretty good but I'd want to take a really careful look at the rounding cases if we decide we do want to go forward with this).
Created attachment 154731 [details] Patch