Bug 90022 - [Chromium] Skia <canvas> should respect webkitBackingStorePixelRatio
Summary: [Chromium] Skia <canvas> should respect webkitBackingStorePixelRatio
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Stephen White
URL:
Keywords:
Depends on: 83635
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-26 16:00 PDT by Stephen White
Modified: 2013-04-09 13:18 PDT (History)
5 users (show)

See Also:


Attachments
early draft, not for review (14.81 KB, patch)
2012-06-26 16:06 PDT, Stephen White
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-02 (700.17 KB, application/zip)
2012-06-26 18:50 PDT, WebKit Review Bot
no flags Details
Archive of layout-test-results from ec2-cr-linux-03 (757.65 KB, application/zip)
2012-06-26 20:04 PDT, WebKit Review Bot
no flags Details
handle premul/unpremul in putImageData(), fix getImageData() clearing tests (16.05 KB, patch)
2012-06-27 09:28 PDT, Stephen White
no flags Details | Formatted Diff | Diff
Apply scaling in ImageBuffer::draw(), ImageBuffer::drawPattern(), ImageBuffer::toDataURL() (18.49 KB, patch)
2012-06-28 12:07 PDT, Stephen White
no flags Details | Formatted Diff | Diff
Remove LayoutTestController changes (14.17 KB, patch)
2012-06-28 13:35 PDT, Stephen White
no flags Details | Formatted Diff | Diff
Patch (14.68 KB, patch)
2012-07-26 13:22 PDT, Stephen White
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen White 2012-06-26 16:00:54 PDT
Skia <canvas> should respect webkitBackingStorePixelRatio.  It should scale up the ImageBuffers which are created, and scale up the base transform applied to drawing commands to compensate.
Comment 1 Stephen White 2012-06-26 16:06:33 PDT
Created attachment 149623 [details]
early draft, not for review
Comment 2 WebKit Review Bot 2012-06-26 18:50:20 PDT
Comment on attachment 149623 [details]
early draft, not for review

Attachment 149623 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13102568

New failing tests:
canvas/philip/tests/2d.imageData.get.source.outside.html
platform/chromium/virtual/gpu/canvas/philip/tests/2d.imageData.get.source.outside.html
Comment 3 WebKit Review Bot 2012-06-26 18:50:24 PDT
Created attachment 149664 [details]
Archive of layout-test-results from ec2-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 4 WebKit Review Bot 2012-06-26 20:04:35 PDT
Comment on attachment 149623 [details]
early draft, not for review

Attachment 149623 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13093671

New failing tests:
canvas/philip/tests/2d.imageData.get.source.outside.html
platform/chromium/virtual/gpu/canvas/philip/tests/2d.imageData.get.source.outside.html
Comment 5 WebKit Review Bot 2012-06-26 20:04:39 PDT
Created attachment 149670 [details]
Archive of layout-test-results from ec2-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 6 Stephen White 2012-06-27 09:28:06 PDT
Created attachment 149762 [details]
handle premul/unpremul in putImageData(), fix getImageData() clearing tests
Comment 7 Stephen White 2012-06-28 12:07:41 PDT
Created attachment 149983 [details]
Apply scaling in ImageBuffer::draw(), ImageBuffer::drawPattern(), ImageBuffer::toDataURL()
Comment 8 Stephen White 2012-06-28 13:35:36 PDT
Created attachment 149997 [details]
Remove LayoutTestController changes
Comment 9 James Robinson 2012-06-28 13:42:37 PDT
I've said this before I'm sure, but I'm not a fan of this API and don't think we should be shipping this in Chrome.  It's a short-term hack that will stick around in the web platform long after its usefulness has expired.
Comment 10 Stephen White 2012-06-28 13:50:14 PDT
(In reply to comment #9)
> I've said this before I'm sure, but I'm not a fan of this API and don't think we should be shipping this in Chrome.  It's a short-term hack that will stick around in the web platform long after its usefulness has expired.

Yes, I agree.  To be honest, I'd be happier not to land this, if that's the consensus.
Comment 11 James Robinson 2012-06-28 13:56:21 PDT
Comment on attachment 149997 [details]
Remove LayoutTestController changes

R- for now, then.

(FWIW, the code looks pretty good but I'd want to take a really careful look at the rounding cases if we decide we do want to go forward with this).
Comment 12 Stephen White 2012-07-26 13:22:32 PDT
Created attachment 154731 [details]
Patch