IndexedDB: const-ify IDBKey
Created attachment 149610 [details] Patch
jsbell@ - something we chatted about once that I finally had to deal with :)
tony@ - r? cq?
Comment on attachment 149610 [details] Patch That was easy - LGTM but... View in context: https://bugs.webkit.org/attachment.cgi?id=149610&action=review > Source/WebCore/Modules/indexeddb/IDBKey.h:44 > RefPtr<IDBKey> idbKey = adoptRef(new IDBKey()); Can be further simplified down to: return adoptRef(...); > Source/WebCore/Modules/indexeddb/IDBKey.h:50 > + RefPtr<IDBKey> idbKey = adoptRef(new IDBKey(NumberType, number)); Ditto, etc.
Created attachment 149782 [details] Patch
Comment on attachment 149782 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149782&action=review > Source/WebCore/ChangeLog:3 > + IndexedDB: const-ify IDBKey Nit: I would probably use immutable in the title, since it's more descriptive than const-ify. > Source/WebCore/Modules/indexeddb/IDBKey.h:153 > + IDBKey(const String& value) : m_type(StringType), m_string(value), m_number(0), m_sizeEstimate(kOverheadSize + value.length() * sizeof(UChar)) { } Nit: explicit
I'm going to use land-safely even though my comitter status hasn't been updated, so that a committer can re-cq+ it.
(In reply to comment #8) > I'm going to use land-safely even though my comitter status hasn't been updated, so that a committer can re-cq+ it. land-safely should set cq? if you're not in committers.py (this was a recent fix).
Created attachment 149796 [details] Patch for landing
Comment on attachment 149796 [details] Patch for landing Clearing flags on attachment: 149796 Committed r121377: <http://trac.webkit.org/changeset/121377>
All reviewed patches have been landed. Closing bug.