90015 – Enable AVCF hardware video decoding

Bug 90015 - Enable AVCF hardware video decoding

Summary: Enable AVCF hardware video decoding

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Media (show other bugs)
Version:	528+ (Nightly build)
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Eric Carlson

URL:
Keywords:

Depends on:
Blocks:

Reported:	2012-06-26 14:31 PDT by Eric Carlson
Modified:	2012-07-14 19:22 PDT (History)
CC List:	2 users (show)

See Also:

Attachments
Proposed patch (32.84 KB, patch) 2012-07-09 09:28 PDT, Eric Carlson	buildbot: commit-queue-	Details \| Formatted Diff \| Diff
Updated patch. (32.14 KB, patch) 2012-07-09 10:11 PDT, Eric Carlson	buildbot: commit-queue-	Details \| Formatted Diff \| Diff
Updated patch, again. (32.15 KB, patch) 2012-07-09 10:40 PDT, Eric Carlson	no flags	Details \| Formatted Diff \| Diff
Fix the style-bot nit. (32.15 KB, patch) 2012-07-09 11:44 PDT, Eric Carlson	andersca: review+	Details \| Formatted Diff \| Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Eric Carlson 2012-06-26 14:31:00 PDT

AVFoundationCF supports hardware video decoding on some systems, we should enable it when possible.

Comment 1 Eric Carlson 2012-06-26 14:31:15 PDT

<rdar://problem/10770317>

Comment 2 Eric Carlson 2012-07-09 09:28:39 PDT

Created attachment 151256 [details]
Proposed patch

Comment 3 WebKit Review Bot 2012-07-09 09:31:50 PDT

Attachment 151256 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:981:  An else should appear on the same line as the preceding }  [whitespace/newline] [4]
Source/WebCore/platform/win/SoftLinking.h:133:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 Build Bot 2012-07-09 09:51:27 PDT

Comment on attachment 151256 [details]
Proposed patch

Attachment 151256 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13167270

Comment 5 Eric Carlson 2012-07-09 10:11:33 PDT

Created attachment 151265 [details]
Updated patch.

Comment 6 WebKit Review Bot 2012-07-09 10:14:26 PDT

Attachment 151265 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/win/SoftLinking.h:133:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 7 Build Bot 2012-07-09 10:25:21 PDT

Comment on attachment 151265 [details]
Updated patch.

Attachment 151265 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13156963

Comment 8 Eric Carlson 2012-07-09 10:40:47 PDT

Created attachment 151272 [details]
Updated patch, again.

Comment 9 WebKit Review Bot 2012-07-09 10:43:30 PDT

Attachment 151272 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/win/SoftLinking.h:133:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 10 Eric Carlson 2012-07-09 11:44:12 PDT

Created attachment 151288 [details]
Fix the style-bot nit.

Comment 11 Anders Carlsson 2012-07-10 09:59:04 PDT

Comment on attachment 151288 [details]
Fix the style-bot nit.

View in context: https://bugs.webkit.org/attachment.cgi?id=151288&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:3485
> +GraphicsDeviceAdapter* HTMLMediaElement::mediaPlayerGraphicsDeviceAdapter(const MediaPlayer*) const

It's a little ugly to have this be on the HTMLMediaElement, but I can't think of a better solution.

Comment 12 Eric Carlson 2012-07-14 19:22:00 PDT

http://trac.webkit.org/changeset/122676