Bug 90010 - Fix platform picker change handler in garden-o-matic
Summary: Fix platform picker change handler in garden-o-matic
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-26 13:44 PDT by Ojan Vafai
Modified: 2012-06-26 14:22 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.63 KB, patch)
2012-06-26 13:57 PDT, Ojan Vafai 		no flags Details | Formatted Diff | Diff
Patch (2.63 KB, patch)
2012-06-26 13:58 PDT, Ojan Vafai 		simon.fraser: review+
simon.fraser: commit-queue+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2012-06-26 13:44:51 PDT 
Fix platform picker change handler in garden-o-matic
Comment 1 Ojan Vafai 2012-06-26 13:57:37 PDT 
Created attachment 149601 [details]
Patch
Comment 2 Ojan Vafai 2012-06-26 13:58:05 PDT 
Created attachment 149602 [details]
Patch
Comment 3 Simon Fraser (smfr) 2012-06-26 14:04:33 PDT 
Comment on attachment 149602 [details]
Patch

Why doesn't platformSelect.selectedOptions[0] work? It works for me on Mac.
Comment 4 Adam Barth 2012-06-26 14:08:48 PDT 
> Why doesn't platformSelect.selectedOptions[0] work? It works for me on Mac.

Presumably you want to be able to select things other than the zeroth option, right?
Comment 5 Simon Fraser (smfr) 2012-06-26 14:12:17 PDT 
(In reply to comment #4)
> > Why doesn't platformSelect.selectedOptions[0] work? It works for me on Mac.
> 
> Presumably you want to be able to select things other than the zeroth option, right?

No, selectedOptions is a collection of the options that are selected (in the case of a dropdown, just the checked one).
Comment 6 Adam Barth 2012-06-26 14:14:48 PDT 
> No, selectedOptions is a collection of the options that are selected (in the case of a dropdown, just the checked one).

Ah, I misread the diff.
Comment 7 Simon Fraser (smfr) 2012-06-26 14:15:34 PDT 
Comment on attachment 149602 [details]
Patch

OK, now we understand that selectedOptions was rolled out via bug 88749.
Comment 8 Ojan Vafai 2012-06-26 14:22:16 PDT 
Committed r121287: <http://trac.webkit.org/changeset/121287>