Bug 90001 – IndexedDB: Hook up render-side key ASSERTing for get()

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alec Flett]

IndexedDB: Hook up render-side key ASSERTing for get()

[Alec Flett]

Created attachment 149603 [details]
Patch

[WebKit Review Bot]

Attachment 149603 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alec Flett]

jsbell@ - mind a once-over? this is dependent on (and the patch is based on top of) the patch in https://bugs.webkit.org/show_bug.cgi?id=89377 - this won't land cleanly until that bug is fixed.

[Alec Flett]

Created attachment 149604 [details]
Patch

[Joshua Bell]

Comment on attachment 149604 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=149604&action=review

> Source/WebCore/Modules/indexeddb/IDBCursor.cpp:273
> +        // FIXME: Assert until we can actually inject the right value.

This FIXME just describes the current state; change it to describe the desired change.

> Source/WebCore/Modules/indexeddb/IDBCursor.cpp:277
> +            if (!keyPath.isNull()) {

This check is redundant.

> Source/WebCore/Modules/indexeddb/IDBCursor.cpp:278
> +                RefPtr<IDBKey> expectedKey =

Unnecessary line break.

[Alec Flett]

Created attachment 149784 [details]
Patch

[Alec Flett]

Created attachment 149786 [details]
Patch

[Alec Flett]

Hey tony@ - another one here, continuing some refactoring work with some chromium plumbing. r? cq?

[Tony Chang]

Comment on attachment 149786 [details]
Patch

Might be nice to have a clean ews run before landing.

View in context: https://bugs.webkit.org/attachment.cgi?id=149786&action=review

> Source/WebCore/ChangeLog:28
> +        (WebCore):
> +
> [phone]  Joshua Bell  <[e-mail]>
> +

Looks like a merge conflict?

> Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:115
>      virtual void onSuccess(PassRefPtr<IDBTransactionBackendInterface>) { }
>      virtual void onSuccess(PassRefPtr<SerializedScriptValue>) { }
> +    virtual void onSuccess(PassRefPtr<SerializedScriptValue>, PassRefPtr<IDBKey>, const IDBKeyPath&) { }

Nit: Should these all have OVERRIDE?

[Alec Flett]

hmm... somehow my git repository got stuck on a day-old chrome version, which means my webkit diff was broken. new patch coming up (almost identical, but with nits addressed, changelog fixed)

[Alec Flett]

Created attachment 149801 [details]
Patch for landing

[Alec Flett]

jsbell@ - cq? (you reviewed this earlier...)

[WebKit Review Bot]

Comment on attachment 149801 [details]
Patch for landing

Clearing flags on attachment: 149801

Committed r121477: <http://trac.webkit.org/changeset/121477>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.