Bug 89987 – [GTK] Enable MHTML support by default at build time

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Mario Sanchez Prada]

It would be great to enable this by default in WebKitGTK once bug 89978 gets fixed, since MHTML is something we'll be interested in having in the new API for WebKit2GTK+ (see bug 89872 and bug 89873)

[Mario Sanchez Prada]

Created attachment 149545 [details]
Patch proposal

Changed defaults for GTK in NWRT (I'm not updating ORWT, feel free to point out if you think it's needed)

[Mario Sanchez Prada]

Forgot to add dependency

[Martin Robinson]

Comment on attachment 149545 [details]
Patch proposal

Perhaps it makes sense to do this in configure.ac? Carlos, what do you think?

[Mario Sanchez Prada]

Created attachment 149554 [details]
Patch proposal enabling this feature in configure.ac

(In reply to comment #3)
> (From update of attachment 149545 [details])
> Perhaps it makes sense to do this in configure.ac? Carlos, what do you think?

I'm providing another patch with this approach now, not marking the previous one as obsolete yetm in case it was preferred.

One doubt I have at this point is whether I need to do also the change in the perl file or not. Any hint?

[Mario Sanchez Prada]

Created attachment 149701 [details]
Patch proposal

(In reply to comment #4)
> [..·]
> I'm providing another patch with this approach now, not marking the previous one as obsolete yetm in case it was preferred.
> 
> One doubt I have at this point is whether I need to do also the change in the perl file or not. Any hint?

I've double checked this and, indeed, we need to modify both configure.ac and Tools/Scripts/webkitperl/FeatureList.pm:

 - configure.ac: To enable MHTML by default when using ./configure && make
 - Tools/Scripts/webkitperl/FeatureList.pm: To enable MHTML by default when using the build-webkit script.

If I just modify configure.ac, build-webkit will override the default value with its own value.

To be more sure I checked how WebGL feature was enabled by default at build time and found two relevant commits:

 - SVN r101060: Enable WebGL by default (in configure.ac)
 - SVN r116310: WebGL feature is not built anymore through build-webkit after r116251 (in FeatureList.pm)

It seems changing configure.ac (at least for WebGL) used to be enough until r116251, when WebGL was introduced in FeatureList.pm. Makes sense, I think.

So, attaching a new single patch with the two changes in it.

[Mario Sanchez Prada]

Committed r123089: <http://trac.webkit.org/changeset/123089>