Bug 89986 - HTMLStyleElement::removedFrom seems incorrect.
Summary: HTMLStyleElement::removedFrom seems incorrect.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Shinya Kawanaka
URL:
Keywords:
Depends on: 88495
Blocks:
  Show dependency tree / graph
 
Reported: 2012-06-26 09:31 PDT by Shinya Kawanaka
Modified: 2012-06-27 08:18 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.50 KB, patch)
2012-06-26 11:10 PDT, Shinya Kawanaka 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-04 (562.57 KB, application/zip)
2012-06-26 12:23 PDT, WebKit Review Bot 		no flags Details
Patch (2.03 KB, patch)
2012-06-26 15:19 PDT, Shinya Kawanaka 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shinya Kawanaka 2012-06-26 09:31:30 PDT 
A bug similar to Bug 88495 contains.
Comment 1 Shinya Kawanaka 2012-06-26 09:34:01 PDT 
Element::removedFrom has the same thing.
Why taking the treeScope of parent?
I believe node->treeScope() and parentNode()->treeScope() should be the same unless parentNode() does not exist...
Comment 2 Shinya Kawanaka 2012-06-26 10:37:26 PDT 
It seems HTMLElement::removedFrom has similar pattern.
I'm not sure we can remove it, but let me try.
Comment 3 Shinya Kawanaka 2012-06-26 10:48:47 PDT 
Sorry, not HTMLElement but Element.
Comment 4 Shinya Kawanaka 2012-06-26 11:10:15 PDT 
Created attachment 149566 [details]
Patch
Comment 5 Shinya Kawanaka 2012-06-26 11:11:07 PDT 
let me try to use EWS to check this patch does not degrade any tests...
Comment 6 WebKit Review Bot 2012-06-26 12:23:37 PDT 
Comment on attachment 149566 [details]
Patch

Attachment 149566 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13102466

New failing tests:
fast/dom/shadow/get-element-by-id-in-shadow-mutation.html
Comment 7 WebKit Review Bot 2012-06-26 12:23:44 PDT 
Created attachment 149585 [details]
Archive of layout-test-results from ec2-cr-linux-04

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-04  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 8 Shinya Kawanaka 2012-06-26 14:15:28 PDT 
(In reply to comment #7)
> Created an attachment (id=149585) [details]
> Archive of layout-test-results from ec2-cr-linux-04
> 
> The attached test failures were seen while running run-webkit-tests on the chromium-ews.
> Bot: ec2-cr-linux-04  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

Oops...
Comment 9 Shinya Kawanaka 2012-06-26 14:49:28 PDT 
By the way, why don't we just take insertionPoint->treeScope() only?
Let me try to do it.
Comment 10 Shinya Kawanaka 2012-06-26 15:16:03 PDT 
Ah, Element::removedFrom maybe seems OK, because it gets treeScope() and does not get shadowRoot().
Comment 11 Shinya Kawanaka 2012-06-26 15:19:48 PDT 
Created attachment 149614 [details]
Patch
Comment 12 WebKit Review Bot 2012-06-27 08:18:24 PDT 
Comment on attachment 149614 [details]
Patch

Clearing flags on attachment: 149614

Committed r121344: <http://trac.webkit.org/changeset/121344>
Comment 13 WebKit Review Bot 2012-06-27 08:18:29 PDT 
All reviewed patches have been landed.  Closing bug.