Bug 89980 – Unexpected end of style sheet in @font-face rule discards it rather than closes all open constructs

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Alexander Pavlov (apavlov)]

Currently, the first font_face alternative explicitly consumes a '}' and maybe_space following it. This entirely agrees with http://www.w3.org/TR/1998/REC-CSS2-19980512/grammar.html but not with http://www.w3.org/TR/CSS21/syndata.html#parsing-errors, the "Unexpected end of style sheet." item, which says the following:

"User agents must close all open constructs (for example: blocks, parentheses, brackets, rules, strings, and comments) at the end of the style sheet. For example:


  @media screen {
    p:before { content: 'Hello
would be treated the same as:


  @media screen {
    p:before { content: 'Hello'; }
  }
in a conformant UA."

All other block_valid_rule's use either save_block or closing_brace, so an unexpected end of style sheet works fine for them - but not for @font-face.

[Alexander Pavlov (apavlov)]

Created attachment 149532 [details]
Patch

[WebKit Review Bot]

Comment on attachment 149532 [details]
Patch

Clearing flags on attachment: 149532

Committed r121337: <http://trac.webkit.org/changeset/121337>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.