Bug 89980 - Unexpected end of style sheet in @font-face rule discards it rather than closes all open constructs
Summary: Unexpected end of style sheet in @font-face rule discards it rather than clos...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexander Pavlov (apavlov)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-26 07:36 PDT by Alexander Pavlov (apavlov)
Modified: 2012-06-27 04:35 PDT (History)
8 users (show)

See Also:


Attachments
Patch (4.03 KB, patch)
2012-06-26 07:58 PDT, Alexander Pavlov (apavlov)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Pavlov (apavlov) 2012-06-26 07:36:05 PDT
Currently, the first font_face alternative explicitly consumes a '}' and maybe_space following it. This entirely agrees with http://www.w3.org/TR/1998/REC-CSS2-19980512/grammar.html but not with http://www.w3.org/TR/CSS21/syndata.html#parsing-errors, the "Unexpected end of style sheet." item, which says the following:

"User agents must close all open constructs (for example: blocks, parentheses, brackets, rules, strings, and comments) at the end of the style sheet. For example:


  @media screen {
    p:before { content: 'Hello
would be treated the same as:


  @media screen {
    p:before { content: 'Hello'; }
  }
in a conformant UA."

All other block_valid_rule's use either save_block or closing_brace, so an unexpected end of style sheet works fine for them - but not for @font-face.
Comment 1 Alexander Pavlov (apavlov) 2012-06-26 07:58:48 PDT
Created attachment 149532 [details]
Patch
Comment 2 WebKit Review Bot 2012-06-27 04:35:23 PDT
Comment on attachment 149532 [details]
Patch

Clearing flags on attachment: 149532

Committed r121337: <http://trac.webkit.org/changeset/121337>
Comment 3 WebKit Review Bot 2012-06-27 04:35:43 PDT
All reviewed patches have been landed.  Closing bug.