Bug 89974 – [WK2] Move intent delivery code from the frame to the page

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

We need to add for following C API to WKFrame:
void WKFrameDeliverIntent(WKFrameRef frameRef, WKIntentDataRef intent);

Otherwise, the client cannot deliver a Web intent to a frame.

[Chris Dumez]

Created attachment 149518 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 149518 [details]
Patch

Looks good to me, but please lets Anders or Sam have a look before you commit it.

[Sam Weinig]

I have not been following this too closely, and I apologize for that (things are a bit busy here) but is it necessary for this to be at the frame level?  I would love to remove the need for explicit frame objects from the WebKit2 API, so adding things seems like going in the wrong direction.  Let me know if there are some other bugs I can look at for context.

[Chris Dumez]

(In reply to comment #3)
> I have not been following this too closely, and I apologize for that (things are a bit busy here) but is it necessary for this to be at the frame level?  I would love to remove the need for explicit frame objects from the WebKit2 API, so adding things seems like going in the wrong direction.  Let me know if there are some other bugs I can look at for context.

All the WK2 Web Intents patches are marked as dependencies of this meta-bug:
Bug 88303.

[Chris Dumez]

(In reply to comment #3)
> I have not been following this too closely, and I apologize for that (things are a bit busy here) but is it necessary for this to be at the frame level?  I would love to remove the need for explicit frame objects from the WebKit2 API, so adding things seems like going in the wrong direction.  Let me know if there are some other bugs I can look at for context.

I was merely trying to match the WebKit1 implementation. Should I move the intent delivery code to the page then?

[Chris Dumez]

Created attachment 149686 [details]
Patch

Sam, is this what you had in mind?
I moved the intent delivery code from the frame to the page.

[Sam Weinig]

(In reply to comment #6)
> Created an attachment (id=149686) [details]
> Patch
> 
> Sam, is this what you had in mind?
> I moved the intent delivery code from the frame to the page.

Probably, since I don't understand what this feature is supposed to do from the function name, I am not sure why it needs to take happen with regards to frame.

[Chris Dumez]

(In reply to comment #7)
> (In reply to comment #6)
> > Created an attachment (id=149686) [details] [details]
> > Patch
> > 
> > Sam, is this what you had in mind?
> > I moved the intent delivery code from the frame to the page.
> 
> Probably, since I don't understand what this feature is supposed to do from the function name, I am not sure why it needs to take happen with regards to frame.

The point is to deliver a Web Intent to a service (web page that can handle an intent) by exposing it via DOMWindow.intent attribute [1]. My understanding is that a DOM Window is associated to a frame and a page can contain several frames. For this reason, the deliver method is associated to a frame, thus the FrameID in argument.

[1] http://www.w3.org/TR/web-intents/#delivery-and-response-api

[WebKit Review Bot]

Comment on attachment 149686 [details]
Patch

Clearing flags on attachment: 149686

Committed r121590: <http://trac.webkit.org/changeset/121590>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.