Bug 89972 - [EFL] Use Eina_Module API instead of dlopen in PluginPackageEfl
Summary: [EFL] Use Eina_Module API instead of dlopen in PluginPackageEfl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-26 04:57 PDT by Chris Dumez
Modified: 2012-06-28 13:56 PDT (History)
4 users (show)

See Also:


Attachments
Patch (4.59 KB, patch)
2012-06-26 05:01 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-06-26 04:57:27 PDT
PluginPackageEfl is currently using the POSIX dlopen() / dlsym() / dlclose() although EFL has helpers for this in Eina_Module. We should use Eina_Module instead.
Comment 1 Chris Dumez 2012-06-26 05:01:23 PDT
Created attachment 149509 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-06-26 15:56:50 PDT
Comment on attachment 149509 [details]
Patch

Looks good. I'd drop the changes to the way m_loadCount is increased just to make the patch touch as little code as possible, but that's not a blocker.
Comment 3 Chris Dumez 2012-06-26 23:26:59 PDT
(In reply to comment #2)
> (From update of attachment 149509 [details])
> Looks good. I'd drop the changes to the way m_loadCount is increased just to make the patch touch as little code as possible, but that's not a blocker.

The m_loadCount change is still in the same function and it is a harmless change. I don't think it is worth writing another patch for this change and this seemed like a good opportunity to fix it.
Comment 4 Antonio Gomes 2012-06-28 13:03:20 PDT
Comment on attachment 149509 [details]
Patch

I wish we actually had a Unix or Posix file for this, where Gtk, EFl and BlckaBerry could share some code.
Comment 5 WebKit Review Bot 2012-06-28 13:56:45 PDT
Comment on attachment 149509 [details]
Patch

Clearing flags on attachment: 149509

Committed r121467: <http://trac.webkit.org/changeset/121467>
Comment 6 WebKit Review Bot 2012-06-28 13:56:49 PDT
All reviewed patches have been landed.  Closing bug.