RESOLVED FIXED 89972
[EFL] Use Eina_Module API instead of dlopen in PluginPackageEfl 
https://bugs.webkit.org/show_bug.cgi?id=89972
Summary [EFL] Use Eina_Module API instead of dlopen in PluginPackageEfl
Chris Dumez
Reported 2012-06-26 04:57:27 PDT
PluginPackageEfl is currently using the POSIX dlopen() / dlsym() / dlclose() although EFL has helpers for this in Eina_Module. We should use Eina_Module instead.
Attachments
Patch (4.59 KB, patch)
2012-06-26 05:01 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-06-26 05:01:23 PDT
Created attachment 149509 [details] Patch
Raphael Kubo da Costa (:rakuco)
Comment 2 2012-06-26 15:56:50 PDT
Comment on attachment 149509 [details] Patch Looks good. I'd drop the changes to the way m_loadCount is increased just to make the patch touch as little code as possible, but that's not a blocker.
Chris Dumez
Comment 3 2012-06-26 23:26:59 PDT
(In reply to comment #2) > (From update of attachment 149509 [details]) > Looks good. I'd drop the changes to the way m_loadCount is increased just to make the patch touch as little code as possible, but that's not a blocker. The m_loadCount change is still in the same function and it is a harmless change. I don't think it is worth writing another patch for this change and this seemed like a good opportunity to fix it.
Antonio Gomes
Comment 4 2012-06-28 13:03:20 PDT
Comment on attachment 149509 [details] Patch I wish we actually had a Unix or Posix file for this, where Gtk, EFl and BlckaBerry could share some code.
WebKit Review Bot
Comment 5 2012-06-28 13:56:45 PDT
Comment on attachment 149509 [details] Patch Clearing flags on attachment: 149509 Committed r121467: <http://trac.webkit.org/changeset/121467>
WebKit Review Bot
Comment 6 2012-06-28 13:56:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.