Bug 89967 - [Platform] Change implementation of LocaleICU class to support more UDateFormat.
Summary: [Platform] Change implementation of LocaleICU class to support more UDateFormat.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: yosin
URL:
Keywords:
Depends on:
Blocks: 89965
  Show dependency tree / graph
 
Reported: 2012-06-26 03:11 PDT by yosin
Modified: 2012-06-26 23:03 PDT (History)
1 user (show)

See Also:

Attachments
Patch 1 (8.00 KB, patch)
2012-06-26 18:29 PDT, yosin 		no flags Details | Formatted Diff | Diff
Patch 2 (8.02 KB, patch)
2012-06-26 21:59 PDT, yosin 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description yosin 2012-06-26 03:11:02 PDT 
For implementing input type "time", I would like to share code for time format with existing implementation.
Comment 1 yosin 2012-06-26 18:29:37 PDT 
Created attachment 149658 [details]
Patch 1
Comment 2 yosin 2012-06-26 18:29:59 PDT 
Comment on attachment 149658 [details]
Patch 1

Could you review this patch?
Thanks in advance.
Comment 3 Kent Tamura 2012-06-26 21:29:00 PDT 
Comment on attachment 149658 [details]
Patch 1

View in context: https://bugs.webkit.org/attachment.cgi?id=149658&action=review

> Source/WebCore/ChangeLog:3
> +        [Platform][DateTime][ICU] Change implementation of LocaleICU class to support more DateFormat.

[DateTime] and [ICU] look redundant.

What's 'DateFormat'? Do you mean 'UDateFormat'?

> Source/WebCore/ChangeLog:8
> +        This patch changes internal functions of LocalICU class to process

LocalICU -> LocaleICU
Comment 4 yosin 2012-06-26 21:59:25 PDT 
Created attachment 149676 [details]
Patch 2
Comment 5 yosin 2012-06-26 22:01:39 PDT 
Comment on attachment 149676 [details]
Patch 2

Could you review again?
Thanks in advance.
Comment 6 Kent Tamura 2012-06-26 23:00:55 PDT 
Comment on attachment 149676 [details]
Patch 2

Looks ok
Comment 7 yosin 2012-06-26 23:03:43 PDT 
Comment on attachment 149676 [details]
Patch 2

Clearing flags on attachment: 149676

Committed r121321: <http://trac.webkit.org/changeset/121321>
Comment 8 yosin 2012-06-26 23:03:49 PDT 
All reviewed patches have been landed.  Closing bug.