Bug 89961 - Web Inspector: Add DirectoryContentView for FileSystemView
Summary: Web Inspector: Add DirectoryContentView for FileSystemView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Taiju Tsuiki
URL:
Keywords:
Depends on: 73301 87856
Blocks: 68203 90361
  Show dependency tree / graph
 
Reported: 2012-06-26 02:03 PDT by Taiju Tsuiki
Modified: 2012-07-02 05:08 PDT (History)
11 users (show)

See Also:

Attachments
Screenshot (51.72 KB, image/png)
2012-06-26 02:03 PDT, Taiju Tsuiki 		no flags Details
Patch (10.72 KB, patch)
2012-06-26 02:05 PDT, Taiju Tsuiki 		no flags Details | Formatted Diff | Diff
Patch (11.70 KB, patch)
2012-07-01 21:57 PDT, Taiju Tsuiki 		no flags Details | Formatted Diff | Diff
Patch (11.52 KB, patch)
2012-07-02 00:08 PDT, Taiju Tsuiki 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Taiju Tsuiki 2012-06-26 02:03:43 PDT 
Created attachment 149487 [details]
Screenshot

After FileSystemView landed, I'd like to add a view to show details of directory contents.
This patch adds DirectoryContentView based on DataGrid, showing name, URL, type and modification time.
Comment 1 Taiju Tsuiki 2012-06-26 02:05:58 PDT 
Created attachment 149489 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-06-29 01:06:42 PDT 
Comment on attachment 149489 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=149489&action=review

> Source/WebCore/inspector/front-end/DirectoryContentView.js:60
> +WebInspector.DirectoryContentView.columnIndices = {

We prefer indexes in inspector code.

> Source/WebCore/inspector/front-end/DirectoryContentView.js:61
> +    NAME: 0,

Name

> Source/WebCore/inspector/front-end/DirectoryContentView.js:63
> +    TYPE: 2,

Type

> Source/WebCore/inspector/front-end/DirectoryContentView.js:64
> +    SIZE: 3,

Size

> Source/WebCore/inspector/front-end/DirectoryContentView.js:65
> +    MTIME: 4

ModificationTime

> Source/WebCore/inspector/front-end/DirectoryContentView.js:100
> +        if ("size" in metadata)

Isn't size always available?

> Source/WebCore/inspector/front-end/FileSystemView.js:98
> +            } else {

else
    return
Comment 3 Taiju Tsuiki 2012-07-01 21:57:31 PDT 
Created attachment 150357 [details]
Patch
Comment 4 Taiju Tsuiki 2012-07-01 23:56:40 PDT 
Comment on attachment 149489 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=149489&action=review

>> Source/WebCore/inspector/front-end/DirectoryContentView.js:60
>> +WebInspector.DirectoryContentView.columnIndices = {
> 
> We prefer indexes in inspector code.

Done

>> Source/WebCore/inspector/front-end/DirectoryContentView.js:61
>> +    NAME: 0,
> 
> Name

Done

>> Source/WebCore/inspector/front-end/DirectoryContentView.js:63
>> +    TYPE: 2,
> 
> Type

Done

>> Source/WebCore/inspector/front-end/DirectoryContentView.js:64
>> +    SIZE: 3,
> 
> Size

Done

>> Source/WebCore/inspector/front-end/DirectoryContentView.js:65
>> +    MTIME: 4
> 
> ModificationTime

Done

>> Source/WebCore/inspector/front-end/DirectoryContentView.js:100
>> +        if ("size" in metadata)
> 
> Isn't size always available?

No, it's not available for directories.

>> Source/WebCore/inspector/front-end/FileSystemView.js:98
>> +            } else {
> 
> else
>     return

Done
Comment 5 Taiju Tsuiki 2012-07-02 00:08:32 PDT 
Created attachment 150366 [details]
Patch
Comment 6 WebKit Review Bot 2012-07-02 05:08:09 PDT 
Comment on attachment 150366 [details]
Patch

Clearing flags on attachment: 150366

Committed r121671: <http://trac.webkit.org/changeset/121671>
Comment 7 WebKit Review Bot 2012-07-02 05:08:14 PDT 
All reviewed patches have been landed.  Closing bug.