According to network information API spec, bandwidth attribute should return double type. But, existing implementation has used *long* and *unsigned int* types.
Created attachment 149486 [details] Patch
CC'ing Adam.
Comment on attachment 149486 [details] Patch LGTM.
Comment on attachment 149486 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149486&action=review > Source/WebKit/efl/WebCoreSupport/NetworkInfoClientEfl.cpp:95 > - return bandwidth / 8; // MB/s > + return static_cast<double>(bandwidth / 8); // MB/s This static_cast shouldn't be needed.
Created attachment 149637 [details] Patch
(In reply to comment #4) > (From update of attachment 149486 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=149486&action=review > > > Source/WebKit/efl/WebCoreSupport/NetworkInfoClientEfl.cpp:95 > > - return bandwidth / 8; // MB/s > > + return static_cast<double>(bandwidth / 8); // MB/s > > This static_cast shouldn't be needed. I fix it. Thanks.
Comment on attachment 149637 [details] Patch Clearing flags on attachment: 149637 Committed r121312: <http://trac.webkit.org/changeset/121312>
All reviewed patches have been landed. Closing bug.