Bug 89957 - [CSS Shapes] Enable CSS Shapes on Windows
Summary: [CSS Shapes] Enable CSS Shapes on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bear Travis
URL:
Keywords:
: 118810 (view as bug list)
Depends on:
Blocks: 89256
  Show dependency tree / graph
 
Reported: 2012-06-26 01:22 PDT by Mihai Balan
Modified: 2013-12-05 15:45 PST (History)
16 users (show)

See Also:

Attachments
Defining ENABLE_CSS_EXCLUSIONS (1.80 KB, patch)
2012-08-27 11:26 PDT, Bear Travis 		no flags Details | Formatted Diff | Diff
Modifying CSSPropertyNames.in (3.05 KB, patch)
2012-08-27 12:24 PDT, Bear Travis 		no flags Details | Formatted Diff | Diff
Updating patch (3.08 KB, patch)
2012-09-13 15:45 PDT, Bear Travis 		no flags Details | Formatted Diff | Diff
Patch enabling Shapes, Shape Tests (8.57 KB, patch)
2013-11-18 17:05 PST, Bear Travis 		no flags Details | Formatted Diff | Diff
Updated patch (2.33 KB, patch)
2013-12-03 15:53 PST, Bear Travis 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Ensuring CSS properties are regenerated (8.33 KB, patch)
2013-12-03 17:37 PST, Bear Travis 		no flags Details | Formatted Diff | Diff
Enabling Tests in TestExpectations (4.67 KB, patch)
2013-12-04 10:54 PST, Bear Travis 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mihai Balan 2012-06-26 01:22:47 PDT 
Currently both CSS regions and exclusions are behind feature defines on Mac and Windows. Mac has them enabled. Trying to enable both regions and exclusions on Windows leads to strange link errors and crashes in DRT (see previous patches and comments for #88645). As such, enabling exclusions (once these land on trunk) was extracted in this bug.

Things to look out for:
  * make sure patch properly builds incrementally (you might have to touch CSSPropertyNames.in)
  * make sure exclusions work in Safari/WebKit on Windows
  * make sure DRT does not crash
Comment 1 Bear Travis 2012-06-26 10:57:24 PDT 
Linking to the master exclusions bug (bug 89256)
Comment 2 Bear Travis 2012-08-27 11:26:22 PDT 
Created attachment 160754 [details]
Defining ENABLE_CSS_EXCLUSIONS
Comment 3 Build Bot 2012-08-27 12:09:10 PDT 
Comment on attachment 160754 [details]
Defining ENABLE_CSS_EXCLUSIONS

Attachment 160754 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13612326
Comment 4 Bear Travis 2012-08-27 12:24:28 PDT 
Created attachment 160775 [details]
Modifying CSSPropertyNames.in

Touching CSSPropertyNames.in to ensure it is properly rebuilt
Comment 5 Bear Travis 2012-09-13 15:45:05 PDT 
Created attachment 163987 [details]
Updating patch
Comment 6 Bear Travis 2013-11-08 17:27:58 PST 
Modifying this bug to reflect the remaining work. Most of the infrastructure was added in bug 118810, but had to be disabled in bug 121879 due to runtime crashes in DRT. The cause of the underlying failure was fixed in bug 121883. Trying to do a bit of history cleanup as well.
Comment 7 Bear Travis 2013-11-08 17:29:33 PST 
*** Bug 118810 has been marked as a duplicate of this bug. ***
Comment 8 Bear Travis 2013-11-18 17:05:24 PST 
Created attachment 217254 [details]
Patch enabling Shapes, Shape Tests
Comment 9 Bear Travis 2013-12-03 15:53:13 PST 
Created attachment 218358 [details]
Updated patch
Comment 10 Build Bot 2013-12-03 16:54:22 PST 
Comment on attachment 218358 [details]
Updated patch

Attachment 218358 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/42978063
Comment 11 Bear Travis 2013-12-03 17:37:54 PST 
Created attachment 218366 [details]
Ensuring CSS properties are regenerated
Comment 12 Bear Travis 2013-12-04 10:54:27 PST 
Created attachment 218417 [details]
Enabling Tests in TestExpectations
Comment 13 Brent Fulgham 2013-12-05 15:14:02 PST 
Comment on attachment 218417 [details]
Enabling Tests in TestExpectations

Looks good. r=me!
Comment 14 WebKit Commit Bot 2013-12-05 15:45:13 PST 
Comment on attachment 218417 [details]
Enabling Tests in TestExpectations

Clearing flags on attachment: 218417

Committed r160200: <http://trac.webkit.org/changeset/160200>
Comment 15 WebKit Commit Bot 2013-12-05 15:45:17 PST 
All reviewed patches have been landed.  Closing bug.