Bug 89932 – JavaScript resources have low priority when SVG is enabled

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Pratik Solanki]

The following change made it so that JavaScript resources have low priority.

https://bugs.webkit.org/show_bug.cgi?id=12499
http://trac.webkit.org/changeset/108785

The problematic part is

--- a/Source/WebCore/loader/cache/CachedResource.cpp
+++ b/Source/WebCore/loader/cache/CachedResource.cpp
@@ -61,6 +61,10 @@ static ResourceLoadPriority defaultPriorityForResourceType(CachedResource::Type
 #endif
             return ResourceLoadPriorityHigh;
         case CachedResource::Script:
+#if ENABLE(SVG)
+        case CachedResource::SVGDocumentResource:
+            return ResourceLoadPriorityLow;
+#endif
         case CachedResource::FontResource:
         case CachedResource::RawResource:
             return ResourceLoadPriorityMedium;

CachedResource::Script now returns ResourceLoadPriorityLow instead of ResourceLoadPriorityMedium when SVG is enabled.

[Pratik Solanki]

<rdar://problem/11741325>

[Pratik Solanki]

Created attachment 149456 [details]
Patch

[Pratik Solanki]

Committed r121231: <http://trac.webkit.org/changeset/121231>

[Darin Adler]

Comment on attachment 149456 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=149456&action=review

> Source/WebCore/ChangeLog:9
> +        r108785 inadvertently lowered the priority of JavaScript resources. Fix the code so we set

It was not r108785. Looking to find out when this regressed.

[Darin Adler]

Comment on attachment 149456 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=149456&action=review

>> Source/WebCore/ChangeLog:9
>> +        r108785 inadvertently lowered the priority of JavaScript resources. Fix the code so we set
> 
> It was not r108785. Looking to find out when this regressed.

Sorry, my bad, it was r108785 exactly as Pratik said. My apologies for the misleading comment.