Bug 89924 - [Texmap] Bug fix typo about computing bytesPerLine in BitmapTextureGL.
Summary: [Texmap] Bug fix typo about computing bytesPerLine in BitmapTextureGL.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-25 17:14 PDT by Dongseong Hwang
Modified: 2012-06-26 06:09 PDT (History)
2 users (show)

See Also:

Attachments
patch (4.13 KB, patch)
2012-06-25 17:16 PDT, Dongseong Hwang 		noam: review+
noam: commit-queue-
Details | Formatted Diff | Diff
patch v.2 (4.13 KB, patch)
2012-06-25 19:18 PDT, Dongseong Hwang 		no flags Details | Formatted Diff | Diff
patch v.3 (4.13 KB, patch)
2012-06-26 01:40 PDT, Dongseong Hwang 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dongseong Hwang 2012-06-25 17:14:20 PDT 
"bytesPerLine == targetRect.width() / 4" is invalid.
This patch amended it into "bytesPerLine == targetRect.width() * 4".
Moreover, changed magic number 4 to bytesPerPixel.
Comment 1 Dongseong Hwang 2012-06-25 17:16:05 PDT 
Created attachment 149400 [details]
patch
Comment 2 Noam Rosenthal 2012-06-25 18:22:26 PDT 
Comment on attachment 149400 [details]
patch

Great! Though ews shows that the patch doesn't apply... do you have other patches up for review that aren't committed yet?
Comment 3 Dongseong Hwang 2012-06-25 19:14:15 PDT 
I think this patch blocks on Bug 89867, but it is strange, because two changes are completely separated.

I will request one time more after Bug 89867 is accepted. :)
Comment 4 Dongseong Hwang 2012-06-25 19:18:53 PDT 
Created attachment 149428 [details]
patch v.2
Comment 5 Dongseong Hwang 2012-06-26 01:40:29 PDT 
Created attachment 149484 [details]
patch v.3

Try again.
Comment 6 WebKit Review Bot 2012-06-26 06:09:39 PDT 
Comment on attachment 149484 [details]
patch v.3

Clearing flags on attachment: 149484

Committed r121260: <http://trac.webkit.org/changeset/121260>
Comment 7 WebKit Review Bot 2012-06-26 06:09:44 PDT 
All reviewed patches have been landed.  Closing bug.