Bug 89910 - Fix the css stylesheet for android media controls after recent changes
Summary: Fix the css stylesheet for android media controls after recent changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 66687
  Show dependency treegraph
 
Reported: 2012-06-25 14:24 PDT by Min Qin
Modified: 2012-06-26 09:35 PDT (History)
7 users (show)

See Also:


Attachments
Patch (8.05 KB, patch)
2012-06-25 14:31 PDT, Min Qin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Min Qin 2012-06-25 14:24:46 PDT
Fix the css stylesheet for android media controls after recent changes
Comment 1 Min Qin 2012-06-25 14:31:25 PDT
Created attachment 149360 [details]
Patch
Comment 2 Eric Carlson 2012-06-25 14:41:25 PDT
Comment on attachment 149360 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=149360&action=review

> Source/WebCore/ChangeLog:10
> +        No tests needed, just css changes.
> +

Changes to media controls CSS usually require new test results. Are there no layout tests for Chromium Android?
Comment 3 Min Qin 2012-06-25 14:45:46 PDT
There are currently no new layout tests for chrome on android in webkit. I will update the test expetations later when DumpRenderTree starts running on the bot.
Comment 4 WebKit Review Bot 2012-06-25 18:34:52 PDT
Comment on attachment 149360 [details]
Patch

Clearing flags on attachment: 149360

Committed r121210: <http://trac.webkit.org/changeset/121210>
Comment 5 WebKit Review Bot 2012-06-25 18:34:56 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Eric Carlson 2012-06-26 08:31:36 PDT
(In reply to comment #3)
> There are currently no new layout tests for chrome on android in webkit. 

Then your comment in the ChangeLog, "No tests needed, just css changes", was incorrect.
Comment 7 Min Qin 2012-06-26 09:35:24 PDT
Yes, thanks for pointing out that. I should have put a comment there that chrome on android currently does not have layout test.

(In reply to comment #6)
> (In reply to comment #3)
> > There are currently no new layout tests for chrome on android in webkit. 
> 
> Then your comment in the ChangeLog, "No tests needed, just css changes", was incorrect.