This includes -moz-zoom-in, -moz-zoom-out, -moz-grab, -moz-grabbing etc. from <http://developer.mozilla.org/en/docs/Category:CSS:Mozilla_Extensions>
Created attachment 8400 [details] test case
-moz-alias - same as CSS3 "alias" -moz-cell - same as CSS3 "cell" -moz-context-menu - same as CSS3 "context-menu" -moz-copy - same as CSS3 "copy" -moz-grab -moz-grabbing -moz-spinning - same as CSS2.1 "progress" -moz-zoom-in -moz-zoom-out
Created attachment 13365 [details] adds cursor images for future grabbing and dragging Made these two from the hands in Quicktime (added dropshadows and converted to PNG). This first patch doesn't alter the code, I just want to know if it they look OK.
Should worry about this post-stabilization. Clearing review flag for now.
Created attachment 13529 [details] Adds testcases for Mozilla cursors (no code change)
Comment on attachment 13529 [details] Adds testcases for Mozilla cursors (no code change) Why should we land a test when these cursor types aren't supported yet in our code?
Comment on attachment 13529 [details] Adds testcases for Mozilla cursors (no code change) Seems fine. But if we add these cursors, they need to work with -webkit- names too, not just -moz- ones. r=me
Comment on attachment 13529 [details] Adds testcases for Mozilla cursors (no code change) Clearing this. There's no logical reason to land just a test case like this when the support isn't there.
Created attachment 19473 [details] -webkit-grab & -webkit-grabbing support A small patch to add support for -webkit-grab and -webkit-grabbing cursors. I think this should be enough, because there is no support for any -moz-* feature in webkit so far and I think it would be bad idea to add it.
On one hand, it may be a bad idea indeed - but on the other hand, adding them would help web compatibility. I feel conflicted about this one.
Maybe you are right, but looking at the standard I think it is a bad idea at all to add named custom cursors, because only one named cursor is permitted. So it would have been better to add something like -webkit-cursor:[zoom-in|zoom-out|grab|grabbing|...]
Comment on attachment 19473 [details] -webkit-grab & -webkit-grabbing support Thanks for taking this on. This will break the build on all the non-Mac platforms, since the only definition of the new functions is for Mac. Please fix that. Patch otherwise looks great.
(In reply to comment #10) > On one hand, it may be a bad idea indeed - but on the other hand, adding them > would help web compatibility. I feel conflicted about this one. I think we may indeed want to make the -moz- names work. I'd like to hear Hyatt's thoughts on it.
How about proposing them as additions to CSS on www-style@w3.org?
Created attachment 19501 [details] Patch with dummy implementations for non mac systems Sorry, but I am not able to implement this feature for non mac plattforms, so the default pointer will be used instead of the grab/grabbing pointer
Comment on attachment 19501 [details] Patch with dummy implementations for non mac systems The best behavior for systems where we don't actually have the cursors would probably be to ignore the CSS value as if we didn't understand it. It's not obvious how to code that. I'm not too fond of the "TODO" comments, but maybe that's the way those ports are keeping track of loose ends. Someone needs to look at the cursors to make sure the art is not owned by anyone. r=me
(In reply to comment #15) > Created an attachment (id=19501) [edit] > Patch with dummy implementations for non mac systems > > Sorry, but I am not able to implement this feature for non mac plattforms, so > the default pointer will be used instead of the grab/grabbing pointer then use the notImplemented() function instead of a TODO. We grep for notImplemented and not TODO to find not implemented things.
I'd like to land this, but I'm blocked by the task of making sure that none of this art is owned by anyone. Not sure what to do next.
Is there a good reason not to use +[NSCursor openHandCursor] and +[NSCursor closedHandCursor] for this? I think I'll just land it working that way.
Comment on attachment 19501 [details] Patch with dummy implementations for non mac systems Landed as http://trac.webkit.org/changeset/37902
We added support for grab and grabbing with the -webkit- prefix. If you want some additional cursors that aren't supported feel free to file new specific bug reports.