Bug 89877 – [EFL][WK2] Missing ViewIsFocused flag in viewStateDidChange call inside of _ewk_view_smart_focus_out() function.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Piotr Roguski]

WebPageProxy::ViewIsFocused flag needs to be added to WebPageProxy::ViewFocusStateChange() call inside of _ewk_view_smart_focus_out(). Omitting this flag will prevent ViewFocusStateChange() from sending Messages::WebPage::SetFocused(bool):


void WebPageProxy::viewStateDidChange(ViewStateFlags flags)
{
    if (!isValid())
        return;

    if (flags & ViewIsFocused)
        process()->send(Messages::WebPage::SetFocused(m_pageClient->isViewFocused()), m_pageID);
/* ... */
}

[Piotr Roguski]

Created attachment 149739 [details]
Patch adding missing flag to viewStateDidChange call

[Grzegorz Czajkowski]

LGTM.
We need to send a message to WebProcess - SetFocused(false) on focus out. We are doing the same in WK1 directly on FocusController object:
http://trac.webkit.org/browser/trunk/Source/WebKit/efl/ewk/ewk_view.cpp#L560

[WebKit Review Bot]

Comment on attachment 149739 [details]
Patch adding missing flag to viewStateDidChange call

Clearing flags on attachment: 149739

Committed r121770: <http://trac.webkit.org/changeset/121770>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.