RESOLVED FIXED 89859
Remove responseBlob field from XMLHttpResponse.idl 
https://bugs.webkit.org/show_bug.cgi?id=89859
Summary Remove responseBlob field from XMLHttpResponse.idl
Kinuko Yasuda
Reported 2012-06-25 00:39:48 PDT
Remove XMLHttpResponse.responseBlob from XMLHttpResponse.idl, which has only been exposed for a very limited time (since r120574) but probably should not have been done so since XHR2 spec no longer has the field. A quick search also showed that no one seems to be using the field.
Attachments
Patch (1.81 KB, patch)
2012-06-25 01:09 PDT, Kinuko Yasuda 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kinuko Yasuda
Comment 1 2012-06-25 01:09:01 PDT
Created attachment 149262 [details] Patch
Eric Seidel (no email)
Comment 2 2012-06-25 09:22:45 PDT
Comment on attachment 149262 [details] Patch I'm surprised I didn't add any testing. I'm also surprised this is being removed... but OK.
Adam Barth
Comment 3 2012-06-25 09:32:23 PDT
I wonder if we should research why this was removed from the spec. Is there another way of getting a blob out of an XHR? I know there are some plans to use XHR and Blobs in Chrome apps to store things like images in IndedDB for offline viewing. We might want to check with Mihai to be on the safe side.
Mihai Parparita
Comment 4 2012-06-25 09:34:55 PDT
(In reply to comment #3) > I wonder if we should research why this was removed from the spec. Is there another way of getting a blob out of an XHR? > > I know there are some plans to use XHR and Blobs in Chrome apps to store things like images in IndedDB for offline viewing. We might want to check with Mihai to be on the safe side. You can still get a blob by setting the responseType to 'blob' and checking the .response property. This patch LGTM as far as apps are concerned.
Adam Barth
Comment 5 2012-06-25 09:35:58 PDT
Comment on attachment 149262 [details] Patch Ok. That sounds like a nicer API anyway, which is probably why it was removed from the spec. Thanks!
WebKit Review Bot
Comment 6 2012-06-25 09:56:39 PDT
Comment on attachment 149262 [details] Patch Clearing flags on attachment: 149262 Committed r121161: <http://trac.webkit.org/changeset/121161>
WebKit Review Bot
Comment 7 2012-06-25 09:56:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.