Bug 89859 - Remove responseBlob field from XMLHttpResponse.idl
Summary: Remove responseBlob field from XMLHttpResponse.idl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kinuko Yasuda
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-25 00:39 PDT by Kinuko Yasuda
Modified: 2012-06-25 09:56 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.81 KB, patch)
2012-06-25 01:09 PDT, Kinuko Yasuda
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kinuko Yasuda 2012-06-25 00:39:48 PDT
Remove XMLHttpResponse.responseBlob from XMLHttpResponse.idl, which has only been exposed for a very limited time (since r120574) but probably should not have been done so since XHR2 spec no longer has the field.
A quick search also showed that no one seems to be using the field.
Comment 1 Kinuko Yasuda 2012-06-25 01:09:01 PDT
Created attachment 149262 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-06-25 09:22:45 PDT
Comment on attachment 149262 [details]
Patch

I'm surprised I didn't add any testing.  I'm also surprised this is being removed...  but OK.
Comment 3 Adam Barth 2012-06-25 09:32:23 PDT
I wonder if we should research why this was removed from the spec.  Is there another way of getting a blob out of an XHR?

I know there are some plans to use XHR and Blobs in Chrome apps to store things like images in IndedDB for offline viewing.  We might want to check with Mihai to be on the safe side.
Comment 4 Mihai Parparita 2012-06-25 09:34:55 PDT
(In reply to comment #3)
> I wonder if we should research why this was removed from the spec.  Is there another way of getting a blob out of an XHR?
> 
> I know there are some plans to use XHR and Blobs in Chrome apps to store things like images in IndedDB for offline viewing.  We might want to check with Mihai to be on the safe side.

You can still get a blob by setting the responseType to 'blob' and checking the .response property. This patch LGTM as far as apps are concerned.
Comment 5 Adam Barth 2012-06-25 09:35:58 PDT
Comment on attachment 149262 [details]
Patch

Ok.  That sounds like a nicer API anyway, which is probably why it was removed from the spec.  Thanks!
Comment 6 WebKit Review Bot 2012-06-25 09:56:39 PDT
Comment on attachment 149262 [details]
Patch

Clearing flags on attachment: 149262

Committed r121161: <http://trac.webkit.org/changeset/121161>
Comment 7 WebKit Review Bot 2012-06-25 09:56:46 PDT
All reviewed patches have been landed.  Closing bug.