RESOLVED FIXED 89858
[GTK] Test /webkit2/WebKitWebView/permission-requests fails due to a runtime warning 
https://bugs.webkit.org/show_bug.cgi?id=89858
Summary [GTK] Test /webkit2/WebKitWebView/permission-requests fails due to a runtime ...
Carlos Garcia Campos
Reported 2012-06-25 00:37:19 PDT
It doesn't happen in the bots, though, so I guess it's a bug in some versions of geoclue. /webkit2/WebKitWebView/permission-requests: ** (Programs/WebKit2APITests/TestWebKitWebView:26401): WARNING **: Metadata for error domain "geoclue-error-quark" already registered We don't register any error quark for geolocation errors, so this is a geoclue issue. Warnings are critical by default when running unit tests, so we need make them not critical for this particular test case to make it pass.
Attachments
Patch (1.98 KB, patch)
2012-06-25 00:42 PDT, Carlos Garcia Campos 		xan.lopez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2012-06-25 00:42:45 PDT
Created attachment 149260 [details] Patch
WebKit Review Bot
Comment 2 2012-06-25 00:47:03 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Xan Lopez
Comment 3 2012-06-25 00:53:13 PDT
Comment on attachment 149260 [details] Patch r=me
Carlos Garcia Campos
Comment 4 2012-06-25 01:42:58 PDT
Committed r121143: <http://trac.webkit.org/changeset/121143>
Note You need to log in before you can comment on or make changes to this bug.