Bug 89857 - [BlackBerry] Fill more data in device motion event
Summary: [BlackBerry] Fill more data in device motion event
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Leo Yang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-25 00:11 PDT by Leo Yang
Modified: 2013-01-04 09:45 PST (History)
7 users (show)

See Also:

Attachments
Patch (3.03 KB, patch)
2012-06-25 00:20 PDT, Leo Yang 		no flags Details | Formatted Diff | Diff
Patch v2 (3.06 KB, patch)
2012-06-25 00:23 PDT, Leo Yang 		no flags Details | Formatted Diff | Diff
Patch v3 (3.11 KB, patch)
2012-06-25 00:25 PDT, Leo Yang 		tonikitoo: review+
tonikitoo: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (3.23 KB, patch)
2012-06-25 19:23 PDT, Leo Yang 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Leo Yang 2012-06-25 00:11:55 PDT 
We need to fill acceleration and rotation rate in device motion event for the blackberry porting.
Comment 1 Leo Yang 2012-06-25 00:20:39 PDT 
Created attachment 149254 [details]
Patch
Comment 2 Leo Yang 2012-06-25 00:23:18 PDT 
Created attachment 149256 [details]
Patch v2
Comment 3 Leo Yang 2012-06-25 00:25:46 PDT 
Created attachment 149257 [details]
Patch v3
Comment 4 Antonio Gomes 2012-06-25 09:56:38 PDT 
Comment on attachment 149257 [details]
Patch v3

View in context: https://bugs.webkit.org/attachment.cgi?id=149257&action=review

> Source/WebKit/blackberry/WebCoreSupport/DeviceMotionClientBlackBerry.cpp:81
> +    RefPtr<DeviceMotionData::Acceleration> acceleration = DeviceMotionData::Acceleration::create(
> +        true, event->acceleration.x, true, event->acceleration.y, true, event->acceleration.z);
> +
> +    RefPtr<DeviceMotionData::Acceleration> accelerationIncludingGravity = DeviceMotionData::Acceleration::create(
> +        true, event->accelerationIncludingGravity.x, true, event->accelerationIncludingGravity.y, true, event->accelerationIncludingGravity.z);
> +
> +    RefPtr<DeviceMotionData::RotationRate> rotationRate = DeviceMotionData::RotationRate::create(
> +        true, event->rotationRate.alpha, true, event->rotationRate.beta, true, event->rotationRate.gamma);

please add comments to clarify what the boolean parameters are.
Comment 5 Leo Yang 2012-06-25 19:23:22 PDT 
Created attachment 149431 [details]
Patch for landing
Comment 6 WebKit Review Bot 2012-06-25 21:32:06 PDT 
Comment on attachment 149431 [details]
Patch for landing

Clearing flags on attachment: 149431

Committed r121225: <http://trac.webkit.org/changeset/121225>
Comment 7 Rob Buis 2013-01-04 09:45:06 PST 
This was landed in r121225, closing.