Use InterpolationMedium on chromium-android
Created attachment 149236 [details] Patch
LGTM. Thanks for the patch
Comment on attachment 149236 [details] Patch Medium and Low both map to bilinear interpolation on the Skia path. While this path is fast, it does generate some pretty ugly aliasing, especially noticeable when downsampling (e.g., twinkling during animation). This decision should really be looked at by a person on the Chrome/Android team (unless Min Qin is, I'm not sure from the ChangeLog).
Yeah, Min Qin is works on chromium-android and originally made this change to the chromium-android branch. I can't speak to whether this is a good idea, but it is what's currently happening on the chromium-android branch.
On chrome on android, we noticed that there are lots of white blocks when scrolling image heavy sites. The problem is caused by slow image decoding and resampling. Changing to bilinear interpolation greatly increase the resampling speed (almost unnoticeable). The display for android devices is comparatively small (4'-10') compared to that of 20'-30' desktop. Decent image quality degration is tolerable on such small screens.
(In reply to comment #5) > On chrome on android, we noticed that there are lots of white blocks when scrolling image heavy sites. The problem is caused by slow image decoding and resampling. Changing to bilinear interpolation greatly increase the resampling speed (almost unnoticeable). > The display for android devices is comparatively small (4'-10') compared to that of 20'-30' desktop. Decent image quality degration is tolerable on such small screens. OK, cool. In that case, could I ask that you use Low rather than Medium? Although they currently both do linear, I have some plans to implement a new resampling method and map Medium to it.
Thanks for the update. Adam, would you please make the corresponding change in upstream?
Created attachment 149313 [details] Patch
Done.
Comment on attachment 149313 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149313&action=review OK > Source/WebCore/ChangeLog:15 > + non-noticable on the trace. Nit: noticable => noticable [sic] (since the word noticeable is misspelled)
Created attachment 149316 [details] Patch for landing
Comment on attachment 149316 [details] Patch for landing Clearing flags on attachment: 149316 Committed r121184: <http://trac.webkit.org/changeset/121184>
All reviewed patches have been landed. Closing bug.