Bug 89836 - Rename isPositioned to isOutOfFlowPositioned for clarity
Summary: Rename isPositioned to isOutOfFlowPositioned for clarity
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-24 16:57 PDT by Simon Fraser (smfr)
Modified: 2012-06-24 17:12 PDT (History)
8 users (show)

See Also:


Attachments
Patch (107.13 KB, patch)
2012-06-24 16:59 PDT, Simon Fraser (smfr)
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2012-06-24 16:57:50 PDT
Rename isPositioned to isOutOfFlowPositioned for clarity
Comment 1 Simon Fraser (smfr) 2012-06-24 16:59:31 PDT
Created attachment 149207 [details]
Patch
Comment 2 Antti Koivisto 2012-06-24 17:04:03 PDT
Comment on attachment 149207 [details]
Patch

r=me
Comment 3 WebKit Review Bot 2012-06-24 17:05:57 PDT
Attachment 149207 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:288:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 35 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Simon Fraser (smfr) 2012-06-24 17:12:10 PDT
http://trac.webkit.org/changeset/121123