Bug 89833 - Change the type of the second argument of FrameSelection::revealSelection to use RevealExtentOption
Summary: Change the type of the second argument of FrameSelection::revealSelection to ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on: 88999
Blocks:
  Show dependency tree / graph
 
Reported: 2012-06-24 12:08 PDT by WebKit Review Bot
Modified: 2012-06-24 17:29 PDT (History)
2 users (show)

See Also:

Attachments
Work in progress (4.91 KB, patch)
2012-06-24 12:18 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (5.81 KB, patch)
2012-06-24 12:58 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch for landing (5.81 KB, patch)
2012-06-24 15:28 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2012-06-24 12:08:43 PDT 
Change the type of the second argument of FrameSelection::revealSelection to use RevealExtentOption
Requested by abarth_ on #webkit.
Comment 1 Adam Barth 2012-06-24 12:09:59 PDT 
As requested by rniwa in Bug 88999.
Comment 2 Adam Barth 2012-06-24 12:18:24 PDT 
Created attachment 149200 [details]
Work in progress
Comment 3 Adam Barth 2012-06-24 12:58:46 PDT 
Created attachment 149202 [details]
Patch
Comment 4 Adam Barth 2012-06-24 15:28:11 PDT 
Created attachment 149205 [details]
Patch for landing
Comment 5 Adam Barth 2012-06-24 15:28:29 PDT 
Comment on attachment 149205 [details]
Patch for landing

Let's give the EWS a chance to tell me what I've broken.
Comment 6 WebKit Review Bot 2012-06-24 17:29:21 PDT 
Comment on attachment 149205 [details]
Patch for landing

Clearing flags on attachment: 149205

Committed r121125: <http://trac.webkit.org/changeset/121125>
Comment 7 WebKit Review Bot 2012-06-24 17:29:26 PDT 
All reviewed patches have been landed.  Closing bug.