Bug 89822 - [chromium] Return has value, in function returning void
Summary: [chromium] Return has value, in function returning void
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-23 22:13 PDT by Kwang Yul Seo
Modified: 2012-06-23 22:29 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.75 KB, patch)
2012-06-23 22:17 PDT, Kwang Yul Seo 		abarth: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2012-06-23 22:13:30 PDT 
A followup for r121091.
Comment 1 Kwang Yul Seo 2012-06-23 22:17:04 PDT 
Created attachment 149184 [details]
Patch
Comment 2 WebKit Review Bot 2012-06-23 22:23:40 PDT 
Comment on attachment 149184 [details]
Patch

Rejecting attachment 149184 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebKit/chromium/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/13029798
Comment 3 Adam Barth 2012-06-23 22:25:27 PDT 
Comment on attachment 149184 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=149184&action=review

> Source/WebKit/chromium/ChangeLog:6
> +        A followup for r121091.

You need to leave in the "Reviewed by NOBODY (OOPS!)" line in the ChangeLog so the tools know to fill in the reviewer.
Comment 4 Kwang Yul Seo 2012-06-23 22:26:57 PDT 
(In reply to comment #3)
> (From update of attachment 149184 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=149184&action=review
> 
> > Source/WebKit/chromium/ChangeLog:6
> > +        A followup for r121091.
> 
> You need to leave in the "Reviewed by NOBODY (OOPS!)" line in the ChangeLog so the tools know to fill in the reviewer.

Oops. I removed the line by accident. I will commit this patch manually after adding you as a reviewer. Thanks.
Comment 5 Kwang Yul Seo 2012-06-23 22:29:47 PDT 
Committed r121108: <http://trac.webkit.org/changeset/121108>