Bug 89822 – [chromium] Return has value, in function returning void

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

[Kwang Yul Seo]

A followup for r121091.

[Kwang Yul Seo]

Created attachment 149184 [details]
Patch

[WebKit Review Bot]

Comment on attachment 149184 [details]
Patch

Rejecting attachment 149184 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebKit/chromium/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/13029798

[Adam Barth]

Comment on attachment 149184 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=149184&action=review

> Source/WebKit/chromium/ChangeLog:6
> +        A followup for r121091.

You need to leave in the "Reviewed by NOBODY (OOPS!)" line in the ChangeLog so the tools know to fill in the reviewer.

[Kwang Yul Seo]

(In reply to comment #3)
> (From update of attachment 149184 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=149184&action=review
> 
> > Source/WebKit/chromium/ChangeLog:6
> > +        A followup for r121091.
> 
> You need to leave in the "Reviewed by NOBODY (OOPS!)" line in the ChangeLog so the tools know to fill in the reviewer.

Oops. I removed the line by accident. I will commit this patch manually after adding you as a reviewer. Thanks.

[Kwang Yul Seo]

Committed r121108: <http://trac.webkit.org/changeset/121108>