Bug 89811 – [Gtk] media/media-blocked-by-beforeload.html is flaky

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Zan Dobersek]

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&revision=121086&tests=media%2Fmedia-blocked-by-beforeload.html

It seems the loadedmetadata event is fired at different times, causing intermittent test failures:
--- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/media/media-blocked-by-beforeload-expected.txt 
+++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/media/media-blocked-by-beforeload-actual.txt 
@@ -30,11 +30,11 @@
 
 EVENT('loadstart')
 
+EVENT('loadedmetadata')
+
+
 EVENT('error')
 EXPECTED (event.target.tagName == 'SOURCE') OK
 EXPECTED (video.error == 'null') OK
-
-EVENT('loadedmetadata')
-
 END OF TEST

[Piotr Grad]

Created attachment 231493 [details]
Patch & layout test

[Eric Carlson]

Comment on attachment 231493 [details]
Patch & layout test

This test is about the error events so I would prefer to leave as much logging in the results about those events as possible. The problem is the order of the 'error' and 'loadedmetadata' events is nondeterministic, so wouldn't it work to just not log the arrival of the 'loadedmetadata' event (remove the "logEvent(evt)" from loadedmetadata)?

[Piotr Grad]

Created attachment 231564 [details]
Patch for layout test

[Eric Carlson]

Comment on attachment 231564 [details]
Patch for layout test

Thank you for sticking with this!

[WebKit Commit Bot]

Comment on attachment 231564 [details]
Patch for layout test

Clearing flags on attachment: 231564

Committed r168973: <http://trac.webkit.org/changeset/168973>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.