Bug 89799 - Web Inspector: fix timeline window auto-sizing logic
Summary: Web Inspector: fix timeline window auto-sizing logic
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks: 116924
  Show dependency tree / graph
 
Reported: 2012-06-22 17:58 PDT by Andrey Kosyakov
Modified: 2014-12-12 14:36 PST (History)
8 users (show)

See Also:

Attachments
Patch (3.40 KB, patch)
2012-06-22 18:06 PDT, Andrey Kosyakov 		pfeldman: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2012-06-22 17:58:49 PDT 
r120891 introduced logic for automatically sizing of Timeline overview window as a matter of reducing the number of window refreshes while recording a new timeline. This doesn't work when there's a non-default window selected.

0. Open inspector, switch to Timeline panel.
1. Press record, record some events, press stop.
2. Select a window in the middle of overview.
3. Toggle "glue records" button back and forth.
4. Resize window to force a refresh

EXPECTED: Window content does not change
ACTUAL: Window content changes upon refresh
Comment 1 Andrey Kosyakov 2012-06-22 18:06:11 PDT 
Created attachment 149148 [details]
Patch
Comment 2 Pavel Feldman 2012-06-22 18:13:05 PDT 
Comment on attachment 149148 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=149148&action=review

> Source/WebCore/inspector/front-end/TimelinePanel.js:674
> +            recordsInWindow.length > lastVisibleLine) {

poor indent.
Comment 3 Brian Burg 2014-12-12 14:36:37 PST 
Closing as invalid, as this bug pertains to the old inspector UI and/or its tests.
Please file a new bug (https://www.webkit.org/new-inspector-bug) if the bug/feature/issue is still relevant to WebKit trunk.