WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
89781
[CSS Shaders] Re-enable the CSS Shaders compile time flag on Safari Mac
https://bugs.webkit.org/show_bug.cgi?id=89781
Summary
[CSS Shaders] Re-enable the CSS Shaders compile time flag on Safari Mac
Alexandru Chiculita
Reported
2012-06-22 14:00:11 PDT
The CSS Shaders compile time flag was disabled, but that makes development hard because the tests are not running. Re-enabling the flag by default on Safari Mac. Note that there's still a runtime flag, which is disabled by default.
Attachments
Patch V1
(7.77 KB, patch)
2012-06-22 15:25 PDT
,
Alexandru Chiculita
buildbot
: commit-queue-
Details
Formatted Diff
Diff
Patch V2
(8.20 KB, patch)
2012-06-22 16:07 PDT
,
Alexandru Chiculita
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Alexandru Chiculita
Comment 1
2012-06-22 15:25:15 PDT
Created
attachment 149120
[details]
Patch V1
Alexandru Chiculita
Comment 2
2012-06-22 15:28:34 PDT
(In reply to
comment #0
)
> Note that there's still a runtime flag, which is disabled by default.
Actually, the runtime flag is enabled on Safari for Mac, but the feature is disabled because WebGL is not enabled by default.
Build Bot
Comment 3
2012-06-22 15:38:43 PDT
Comment on
attachment 149120
[details]
Patch V1
Attachment 149120
[details]
did not pass mac-ews (mac): Output:
http://queues.webkit.org/results/13033533
Alexandru Chiculita
Comment 4
2012-06-22 16:02:47 PDT
(In reply to
comment #3
)
> (From update of
attachment 149120
[details]
) >
Attachment 149120
[details]
did not pass mac-ews (mac): > Output:
http://queues.webkit.org/results/13033533
I suppose I need to touch the css keywords files, otherwise the incremental build will not pick it up.
Alexandru Chiculita
Comment 5
2012-06-22 16:07:10 PDT
Created
attachment 149128
[details]
Patch V2 Added empty line in css/CSSValueKeywords.in to force a rebuild.
WebKit Review Bot
Comment 6
2012-06-22 18:24:06 PDT
Comment on
attachment 149128
[details]
Patch V2 Clearing flags on attachment: 149128 Committed
r121083
: <
http://trac.webkit.org/changeset/121083
>
WebKit Review Bot
Comment 7
2012-06-22 18:24:13 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug