Bug 89781 - [CSS Shaders] Re-enable the CSS Shaders compile time flag on Safari Mac
Summary: [CSS Shaders] Re-enable the CSS Shaders compile time flag on Safari Mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexandru Chiculita
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-22 14:00 PDT by Alexandru Chiculita
Modified: 2012-06-22 18:24 PDT (History)
5 users (show)

See Also:


Attachments
Patch V1 (7.77 KB, patch)
2012-06-22 15:25 PDT, Alexandru Chiculita
buildbot: commit-queue-
Details | Formatted Diff | Diff
Patch V2 (8.20 KB, patch)
2012-06-22 16:07 PDT, Alexandru Chiculita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandru Chiculita 2012-06-22 14:00:11 PDT
The CSS Shaders compile time flag was disabled, but that makes development hard because the tests are not running. Re-enabling the flag by default on Safari Mac.

Note that there's still a runtime flag, which is disabled by default.
Comment 1 Alexandru Chiculita 2012-06-22 15:25:15 PDT
Created attachment 149120 [details]
Patch V1
Comment 2 Alexandru Chiculita 2012-06-22 15:28:34 PDT
(In reply to comment #0)
> Note that there's still a runtime flag, which is disabled by default.
Actually, the runtime flag is enabled on Safari for Mac, but the feature is disabled because WebGL is not enabled by default.
Comment 3 Build Bot 2012-06-22 15:38:43 PDT
Comment on attachment 149120 [details]
Patch V1

Attachment 149120 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13033533
Comment 4 Alexandru Chiculita 2012-06-22 16:02:47 PDT
(In reply to comment #3)
> (From update of attachment 149120 [details])
> Attachment 149120 [details] did not pass mac-ews (mac):
> Output: http://queues.webkit.org/results/13033533

I suppose I need to touch the css keywords files, otherwise the incremental build will not pick it up.
Comment 5 Alexandru Chiculita 2012-06-22 16:07:10 PDT
Created attachment 149128 [details]
Patch V2

Added empty line in css/CSSValueKeywords.in to force a rebuild.
Comment 6 WebKit Review Bot 2012-06-22 18:24:06 PDT
Comment on attachment 149128 [details]
Patch V2

Clearing flags on attachment: 149128

Committed r121083: <http://trac.webkit.org/changeset/121083>
Comment 7 WebKit Review Bot 2012-06-22 18:24:13 PDT
All reviewed patches have been landed.  Closing bug.