Bug 89781 – [CSS Shaders] Re-enable the CSS Shaders compile time flag on Safari Mac

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Alexandru Chiculita]

The CSS Shaders compile time flag was disabled, but that makes development hard because the tests are not running. Re-enabling the flag by default on Safari Mac.

Note that there's still a runtime flag, which is disabled by default.

[Alexandru Chiculita]

Created attachment 149120 [details]
Patch V1

[Alexandru Chiculita]

(In reply to comment #0)
> Note that there's still a runtime flag, which is disabled by default.
Actually, the runtime flag is enabled on Safari for Mac, but the feature is disabled because WebGL is not enabled by default.

[Build Bot]

Comment on attachment 149120 [details]
Patch V1

Attachment 149120 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13033533

[Alexandru Chiculita]

(In reply to comment #3)
> (From update of attachment 149120 [details])
> Attachment 149120 [details] did not pass mac-ews (mac):
> Output: http://queues.webkit.org/results/13033533

I suppose I need to touch the css keywords files, otherwise the incremental build will not pick it up.

[Alexandru Chiculita]

Created attachment 149128 [details]
Patch V2

Added empty line in css/CSSValueKeywords.in to force a rebuild.

[WebKit Review Bot]

Comment on attachment 149128 [details]
Patch V2

Clearing flags on attachment: 149128

Committed r121083: <http://trac.webkit.org/changeset/121083>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.