89779 – [BlackBerry] Add JSC statistics into about:memory

Bug 89779 - [BlackBerry] Add JSC statistics into about:memory

Summary: [BlackBerry] Add JSC statistics into about:memory

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	WebKit BlackBerry (show other bugs)
Version:	528+ (Nightly build)
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Nobody

URL:
Keywords:

Depends on:
Blocks:

Reported:	2012-06-22 12:58 PDT by Yong Li
Modified:	2012-06-26 12:56 PDT (History)
CC List:	3 users (show)

See Also:

Attachments
the patch (8.04 KB, patch) 2012-06-25 11:17 PDT, Yong Li	rwlbuis: review-	Details \| Formatted Diff \| Diff
try again (7.97 KB, patch) 2012-06-25 11:26 PDT, Yong Li	no flags	Details \| Formatted Diff \| Diff
Try again (7.96 KB, patch) 2012-06-25 11:27 PDT, Yong Li	rwlbuis: review-	Details \| Formatted Diff \| Diff
got rid of typos (8.00 KB, patch) 2012-06-25 11:40 PDT, Yong Li	no flags	Details \| Formatted Diff \| Diff
the patch (666 bytes, patch) 2012-06-26 11:46 PDT, Yong Li	rwlbuis: review-	Details \| Formatted Diff \| Diff
to commit (1.27 KB, patch) 2012-06-26 11:52 PDT, Yong Li	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Yong Li 2012-06-22 12:58:27 PDT

Add JSC statistics into about:memory page.

Comment 1 Yong Li 2012-06-25 11:17:16 PDT

Created attachment 149328 [details]
the patch

Comment 2 Rob Buis 2012-06-25 11:20:36 PDT

Comment on attachment 149328 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=149328&action=review

Some typos still.

> Source/JavaScriptCore/PlatformBlackBerry.cmake:13
> +IF (NOT DEFINED PUBLIC_BIULD OR NOT PUBLIC_BIULD)

Tyop?

> Source/WebKit/blackberry/WebCoreSupport/AboutData.cpp:247
> +    page += "<h2>JS engnine memory usage</h2><table align=\"center\" rules=\"all\">";

engine

> Source/WebKit/blackberry/WebCoreSupport/AboutData.cpp:256
> +    page += numberToHTMLTr("Protected gloal object count", mainHeap.protectedGlobalObjectCount());

global

Comment 3 Yong Li 2012-06-25 11:26:37 PDT

Created attachment 149332 [details]
try again

Comment 4 Yong Li 2012-06-25 11:27:46 PDT

Created attachment 149334 [details]
Try again

Comment 5 Rob Buis 2012-06-25 11:34:42 PDT

Comment on attachment 149334 [details]
Try again

View in context: https://bugs.webkit.org/attachment.cgi?id=149334&action=review

Looks good, some typo fixes still + ChangeLog update.

> Source/JavaScriptCore/ChangeLog:8
> +        Set JITBytes for BlackBerry port.

Please add that we use MemoryStatistics.cpp now and maybe why.

Comment 6 Yong Li 2012-06-25 11:40:57 PDT

Created attachment 149335 [details]
got rid of typos

Comment 7 Rob Buis 2012-06-25 11:46:21 PDT

Comment on attachment 149335 [details]
got rid of typos

LGTM.

Comment 8 WebKit Review Bot 2012-06-25 17:08:39 PDT

Comment on attachment 149335 [details]
got rid of typos

Clearing flags on attachment: 149335

Committed r121196: <http://trac.webkit.org/changeset/121196>

Comment 9 WebKit Review Bot 2012-06-25 17:08:51 PDT

All reviewed patches have been landed.  Closing bug.

Comment 10 Yong Li 2012-06-26 11:13:43 PDT

reopening to fix non-JIT build

Comment 11 Yong Li 2012-06-26 11:46:54 PDT

Created attachment 149577 [details]
the patch

Comment 12 Rob Buis 2012-06-26 11:50:22 PDT

Comment on attachment 149577 [details]
the patch

LGTM.

Comment 13 Yong Li 2012-06-26 11:52:41 PDT

Created attachment 149578 [details]
to commit

Comment 14 Rob Buis 2012-06-26 11:52:43 PDT

Comment on attachment 149577 [details]
the patch

Oops, misses ChangeLog.

Comment 15 WebKit Review Bot 2012-06-26 12:55:49 PDT

Comment on attachment 149578 [details]
to commit

Clearing flags on attachment: 149578

Committed r121282: <http://trac.webkit.org/changeset/121282>

Comment 16 WebKit Review Bot 2012-06-26 12:56:08 PDT

All reviewed patches have been landed.  Closing bug.