Bug 89772 - [BlackBerry] Tap highlight fade animations are added to overlay continuously during pinch zoom.
Summary: [BlackBerry] Tap highlight fade animations are added to overlay continuously ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andrew Lo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-22 11:21 PDT by Andrew Lo
Modified: 2012-06-22 12:17 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.80 KB, patch)
2012-06-22 11:27 PDT, Andrew Lo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Lo 2012-06-22 11:21:54 PDT
When pinch zooming & setting scroll position, the UI thread calls DefaultTapHighlight::hide continuously to make sure it isn't visible.

Calling hide when it is already hidden should do nothing. However calling it from the UI thread now keeps creating & adding fade animations, since the visible flag check is in the webkit thread branch only.

This results in the tap highlight being visible during zoom after the first fade out.
Comment 1 Andrew Lo 2012-06-22 11:27:53 PDT
Created attachment 149072 [details]
Patch
Comment 2 WebKit Review Bot 2012-06-22 12:16:48 PDT
Comment on attachment 149072 [details]
Patch

Clearing flags on attachment: 149072

Committed r121049: <http://trac.webkit.org/changeset/121049>
Comment 3 WebKit Review Bot 2012-06-22 12:17:06 PDT
All reviewed patches have been landed.  Closing bug.