Bug 89771 - Web Inspector: speed up Timeline and Elements panel rendering
Summary: Web Inspector: speed up Timeline and Elements panel rendering
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-22 11:10 PDT by Pavel Feldman
Modified: 2012-06-24 00:27 PDT (History)
12 users (show)

See Also:

Attachments
Patch (7.89 KB, patch)
2012-06-22 11:15 PDT, Pavel Feldman 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-01 (681.41 KB, application/zip)
2012-06-22 13:06 PDT, WebKit Review Bot 		no flags Details
Patch (9.67 KB, patch)
2012-06-22 15:03 PDT, Pavel Feldman 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-06-22 11:10:27 PDT 
Few findings using the new timeline are fixed
Comment 1 Pavel Feldman 2012-06-22 11:15:03 PDT 
Created attachment 149066 [details]
Patch
Comment 2 Andrey Adaikin 2012-06-22 11:21:54 PDT 
Comment on attachment 149066 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=149066&action=review

> Source/WebCore/inspector/front-end/TimelinePanel.js:750
>              this._containerElement.scrollTop = (totalHeight - this._containerElement.offsetHeight);

also update this._scrollTop here?
Comment 3 Andrey Kosyakov 2012-06-22 11:55:11 PDT 
Comment on attachment 149066 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=149066&action=review

> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:1848
> +        originalScrollTop = treeOutlineContainerElement.scrollTop;

var?

> Source/WebCore/inspector/front-end/TimelinePanel.js:-529
> -        this._closeRecordDetails();
> -        this._scheduleRefresh(false);

Why did this go?
Comment 4 WebKit Review Bot 2012-06-22 13:06:05 PDT 
Comment on attachment 149066 [details]
Patch

Attachment 149066 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13084081

New failing tests:
inspector/debugger/dom-breakpoints.html
Comment 5 WebKit Review Bot 2012-06-22 13:06:15 PDT 
Created attachment 149090 [details]
Archive of layout-test-results from ec2-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 6 Pavel Feldman 2012-06-22 15:03:20 PDT 
Created attachment 149112 [details]
Patch
Comment 7 Andrey Kosyakov 2012-06-22 18:14:41 PDT 
Comment on attachment 149112 [details]
Patch

LGTM
Comment 8 WebKit Review Bot 2012-06-24 00:27:21 PDT 
Comment on attachment 149112 [details]
Patch

Clearing flags on attachment: 149112

Committed r121112: <http://trac.webkit.org/changeset/121112>
Comment 9 WebKit Review Bot 2012-06-24 00:27:27 PDT 
All reviewed patches have been landed.  Closing bug.