Bug 89770 - [Gtk] REGRESSION(r120918): Causes flaky DND tests
Summary: [Gtk] REGRESSION(r120918): Causes flaky DND tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-22 11:02 PDT by Zan Dobersek
Modified: 2012-06-23 22:32 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.63 KB, patch)
2012-06-23 00:23 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2012-06-22 11:02:28 PDT
r120918[1] caused some drag-and-drop tests in fast/events to start failing, however they pass when rerun and are therefor categorized as flaky.

I'll not add expectations for these just yet as I'm hoping the issue will be resolved quickly.

[1] - http://trac.webkit.org/changeset/120918/
Comment 1 Zan Dobersek 2012-06-23 00:23:00 PDT
Created attachment 149169 [details]
Patch
Comment 2 Zan Dobersek 2012-06-23 00:33:32 PDT
(In reply to comment #1)
> Created an attachment (id=149169) [details]
> Patch

It turns out fast/events/domactivate-sets-underlying-click-event-as-handled.html was timing out because of the modal dialog being run in the previous implementation of ChromeClient::runOpenPanel. Current implementation of that method displays the dialog in a non-modal way though, but that's causing problems in drag-and-drop tests as the dialog stays around.

The solution is to not show any file chooser dialog by returning TRUE in web view's run-file-chooser signal handler.
Comment 3 Zan Dobersek 2012-06-23 22:32:13 PDT
Comment on attachment 149169 [details]
Patch

Clearing flags on attachment: 149169

Committed r121109: <http://trac.webkit.org/changeset/121109>
Comment 4 Zan Dobersek 2012-06-23 22:32:20 PDT
All reviewed patches have been landed.  Closing bug.