We cannot currently accelerate rotations that are >= 180 because of the way that we handle blending. The code that currently handles this is not in the right spot, nor is it quite suited to our needs.
Created attachment 149052 [details] Patch
Attachment 149052 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/graphics/chromium/AnimationTranslationUtil.cpp:170: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 149059 [details] Patch Make the style bot happy.
Comment on attachment 149059 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149059&action=review > Source/WebCore/ChangeLog:8 > + No new tests. Functionality covered by existing tests. which tests?
Created attachment 149083 [details] Patch There was a test for large rotations, but added new tests for cases the old code did not deal with.
Created attachment 149084 [details] Patch Sorry for the spam. Last patch was a dud.
Comment on attachment 149084 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149084&action=review > Source/WebCore/platform/graphics/chromium/AnimationTranslationUtil.cpp:140 > +bool causesRotationOfMoreThan180Degrees(const TransformAnimationValue* value, const TransformAnimationValue* lastValue) bikeshed: AtLeast180Degrees?
Created attachment 149085 [details] Patch > bikeshed: AtLeast180Degrees? SG. Done.
Created attachment 150642 [details] Patch for landing
Comment on attachment 150642 [details] Patch for landing Rejecting attachment 150642 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: hanize/_urllib2_fork.py", line 332, in _call_chain result = func(*args) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open return self.do_open(conn_factory, req) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open raise URLError(err) urllib2.URLError: <urlopen error [Errno -3] Temporary failure in name resolution> Full output: http://queues.webkit.org/results/13127575
Comment on attachment 150642 [details] Patch for landing Clearing flags on attachment: 150642 Committed r121844: <http://trac.webkit.org/changeset/121844>
All reviewed patches have been landed. Closing bug.