Bug 89761 - [Chromium/Skia] Increase the GrContext texture cache count cap to 2K
Summary: [Chromium/Skia] Increase the GrContext texture cache count cap to 2K
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brian Salomon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-22 08:48 PDT by Brian Salomon
Modified: 2012-06-22 11:32 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.39 KB, patch)
2012-06-22 08:52 PDT, Brian Salomon 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Salomon 2012-06-22 08:48:27 PDT 
Increase the GrContext texture cache count cap to 2K
Comment 1 Brian Salomon 2012-06-22 08:52:12 PDT 
Created attachment 149035 [details]
Patch
Comment 2 Brian Salomon 2012-06-22 08:56:07 PDT 
I had removed the count cap from Skia but it proved to be problematic. Randomly changing gradients produce many tiny textures. Managing lots of textures causes perf problems on some drivers. We have plans to change how gradient color tables work (http://code.google.com/p/skia/issues/detail?id=670) but if tons of small textures is a problem then it probably makes sense to keep the cap anyway.
Comment 3 Stephen White 2012-06-22 10:25:25 PDT 
Comment on attachment 149035 [details]
Patch

OK.  r=me
Comment 4 Brian Salomon 2012-06-22 10:50:49 PDT 
Oops.. I forgot to set c? after uploading.
Comment 5 WebKit Review Bot 2012-06-22 11:32:22 PDT 
Comment on attachment 149035 [details]
Patch

Clearing flags on attachment: 149035

Committed r121044: <http://trac.webkit.org/changeset/121044>
Comment 6 WebKit Review Bot 2012-06-22 11:32:53 PDT 
All reviewed patches have been landed.  Closing bug.