Bug 89755 - [Qt] When calling accept() on the FilePickerContextObject with an empty list, early return and call reject().
Summary: [Qt] When calling accept() on the FilePickerContextObject with an empty list,...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexis Menard (darktears)
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2012-06-22 05:52 PDT by Alexis Menard (darktears)
Modified: 2012-07-03 06:32 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.61 KB, patch)
2012-06-22 05:53 PDT, Alexis Menard (darktears)
no flags Details | Formatted Diff | Diff
Patch (3.61 KB, patch)
2012-07-02 05:46 PDT, Alexis Menard (darktears)
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-05 (339.47 KB, application/zip)
2012-07-02 07:17 PDT, WebKit Review Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexis Menard (darktears) 2012-06-22 05:52:12 PDT
[Qt] When calling accept() on the FilePickerContextObject with an empty list, early return and call reject().
Comment 1 Alexis Menard (darktears) 2012-06-22 05:53:55 PDT
Created attachment 149006 [details]
Patch
Comment 2 Simon Hausmann 2012-06-26 09:15:45 PDT
Comment on attachment 149006 [details]
Patch

Can you make a unit test for this behaviour?
Comment 3 Alexis Menard (darktears) 2012-07-02 05:46:39 PDT
Created attachment 150404 [details]
Patch
Comment 4 WebKit Review Bot 2012-07-02 07:17:37 PDT
Comment on attachment 150404 [details]
Patch

Attachment 150404 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13135074

New failing tests:
plugins/iframe-shims.html
Comment 5 WebKit Review Bot 2012-07-02 07:17:41 PDT
Created attachment 150417 [details]
Archive of layout-test-results from gce-cr-linux-05

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-05  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 6 Alexis Menard (darktears) 2012-07-02 07:50:08 PDT
(In reply to comment #5)
> Created an attachment (id=150417) [details]
> Archive of layout-test-results from gce-cr-linux-05
> 
> The attached test failures were seen while running run-webkit-tests on the chromium-ews.
> Bot: gce-cr-linux-05  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

False positive obviously as I fix Qt and Qt only :)
Comment 7 Adam Barth 2012-07-02 09:13:50 PDT
> False positive obviously as I fix Qt and Qt only :)

Yes, sorry.  This was caused by the migration.  I'm investigating and will fix.
Comment 8 Alexis Menard (darktears) 2012-07-02 09:16:46 PDT
(In reply to comment #7)
> > False positive obviously as I fix Qt and Qt only :)
> 
> Yes, sorry.  This was caused by the migration.  I'm investigating and will fix.

Don't worry it's no big deal.
Comment 9 WebKit Review Bot 2012-07-03 06:32:47 PDT
Comment on attachment 150404 [details]
Patch

Clearing flags on attachment: 150404

Committed r121761: <http://trac.webkit.org/changeset/121761>
Comment 10 WebKit Review Bot 2012-07-03 06:32:53 PDT
All reviewed patches have been landed.  Closing bug.