Bug 89743 - Web Inspector: InspectorState::updateCookie should not do JSON serialization if unsupported
Summary: Web Inspector: InspectorState::updateCookie should not do JSON serialization ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-06-21 23:47 PDT by Joseph Pecoraro
Modified: 2012-06-22 18:29 PDT (History)
11 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (6.20 KB, patch)
2012-06-21 23:53 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2012-06-21 23:47:45 PDT
It looks like only the Chromium port implements the InspectorStateClient interface to save
InspectorState cookie information. Ports that were doing nothing with this information
are getting the cost of InspectorState JSON serialization. Avoid serialization if the client
does not do anything with InspectorState updates.
Comment 1 Joseph Pecoraro 2012-06-21 23:53:54 PDT
Created attachment 148969 [details]
[PATCH] Proposed Fix

Let the bots run first to make sure I didn't make a typo with the Chromium port, but I think this should be good.
Comment 2 Joseph Pecoraro 2012-06-21 23:54:19 PDT
<rdar://problem/11630358>
Comment 3 WebKit Review Bot 2012-06-22 02:14:15 PDT
Comment on attachment 148969 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 148969

Committed r121013: <http://trac.webkit.org/changeset/121013>
Comment 4 WebKit Review Bot 2012-06-22 02:14:20 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Pavel Feldman 2012-06-22 18:29:13 PDT
Comment on attachment 148969 [details]
[PATCH] Proposed Fix

Looks good to me.