Bug 89739 – Web Inspector: Add frontend-side Entry object to FileSystemModel

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Taiju Tsuiki]

I'd like to add Entry, Directory and File object under FileSystemModel that represent browser side entries.
It will provide handy way to manipulate entries.

This is split out bug/patch from http://webkit.org/b/73301 (Web Inspector: Add FileSystemView).

[Taiju Tsuiki]

Created attachment 148965 [details]
Patch

[Vsevolod Vlasov]

Comment on attachment 148965 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148965&action=review

> Source/WebCore/inspector/front-end/FileSystemModel.js:287
> +    get fileSystemModel() { return this._fileSystemModel; },

Here and below:

get fileSystemModel()
{
    return this._fileSystemModel;
},

Also could you please add compiler annotations to getters (where possible).

[Taiju Tsuiki]

Created attachment 148989 [details]
Patch

[Taiju Tsuiki]

Comment on attachment 148965 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148965&action=review

>> Source/WebCore/inspector/front-end/FileSystemModel.js:287
>> +    get fileSystemModel() { return this._fileSystemModel; },
> 
> Here and below:
> 
> get fileSystemModel()
> {
>     return this._fileSystemModel;
> },
> 
> Also could you please add compiler annotations to getters (where possible).

Done.

[WebKit Review Bot]

Comment on attachment 148989 [details]
Patch

Clearing flags on attachment: 148989

Committed r121017: <http://trac.webkit.org/changeset/121017>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.