Bug 89739 - Web Inspector: Add frontend-side Entry object to FileSystemModel
Summary: Web Inspector: Add frontend-side Entry object to FileSystemModel
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Taiju Tsuiki
URL:
Keywords:
Depends on:
Blocks: 68203 73301 87856
  Show dependency tree / graph
 
Reported: 2012-06-21 23:00 PDT by Taiju Tsuiki
Modified: 2012-06-22 05:36 PDT (History)
11 users (show)

See Also:

Attachments
Patch (6.31 KB, patch)
2012-06-21 23:13 PDT, Taiju Tsuiki 		no flags Details | Formatted Diff | Diff
Patch (6.93 KB, patch)
2012-06-22 03:17 PDT, Taiju Tsuiki 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Taiju Tsuiki 2012-06-21 23:00:35 PDT 
I'd like to add Entry, Directory and File object under FileSystemModel that represent browser side entries.
It will provide handy way to manipulate entries.

This is split out bug/patch from http://webkit.org/b/73301 (Web Inspector: Add FileSystemView).
Comment 1 Taiju Tsuiki 2012-06-21 23:13:53 PDT 
Created attachment 148965 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-06-22 03:08:22 PDT 
Comment on attachment 148965 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148965&action=review

> Source/WebCore/inspector/front-end/FileSystemModel.js:287
> +    get fileSystemModel() { return this._fileSystemModel; },

Here and below:

get fileSystemModel()
{
    return this._fileSystemModel;
},

Also could you please add compiler annotations to getters (where possible).
Comment 3 Taiju Tsuiki 2012-06-22 03:17:42 PDT 
Created attachment 148989 [details]
Patch
Comment 4 Taiju Tsuiki 2012-06-22 03:19:02 PDT 
Comment on attachment 148965 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148965&action=review

>> Source/WebCore/inspector/front-end/FileSystemModel.js:287
>> +    get fileSystemModel() { return this._fileSystemModel; },
> 
> Here and below:
> 
> get fileSystemModel()
> {
>     return this._fileSystemModel;
> },
> 
> Also could you please add compiler annotations to getters (where possible).

Done.
Comment 5 WebKit Review Bot 2012-06-22 05:36:12 PDT 
Comment on attachment 148989 [details]
Patch

Clearing flags on attachment: 148989

Committed r121017: <http://trac.webkit.org/changeset/121017>
Comment 6 WebKit Review Bot 2012-06-22 05:36:16 PDT 
All reviewed patches have been landed.  Closing bug.