Bug 89738 - CSS3 calc: transitions starting and ending with a calc expression move to end state
Summary: CSS3 calc: transitions starting and ending with a calc expression move to end...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike Lawther
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-21 22:58 PDT by Mike Lawther
Modified: 2012-06-24 20:16 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.35 KB, patch)
2012-06-21 23:03 PDT, Mike Lawther 		no flags Details | Formatted Diff | Diff
Patch (4.41 KB, patch)
2012-06-22 08:00 PDT, Mike Lawther 		no flags Details | Formatted Diff | Diff
Patch for landing (4.80 KB, patch)
2012-06-24 17:34 PDT, Mike Lawther 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Lawther 2012-06-21 22:58:51 PDT 
CSS3 calc: transitions starting and ending with a calc expression move to end state
Comment 1 Mike Lawther 2012-06-21 23:03:40 PDT 
Created attachment 148963 [details]
Patch
Comment 2 Mike Lawther 2012-06-22 08:00:15 PDT 
Created attachment 149028 [details]
Patch
Comment 3 Tony Chang 2012-06-22 11:17:17 PDT 
Comment on attachment 149028 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=149028&action=review

This

> LayoutTests/css3/calc/transition-start-end-with-calc.html:7
> +    -webkit-transition: all 0.01s;
> +    -moz-transition: all 0.01s;

Should we use LayoutTests/transitions/resources/transition-test-helpers.js instead of a fast transition?
Comment 4 Mike Lawther 2012-06-24 17:34:46 PDT 
Created attachment 149214 [details]
Patch for landing
Comment 5 Mike Lawther 2012-06-24 17:51:05 PDT 
> Should we use LayoutTests/transitions/resources/transition-test-helpers.js instead of a fast transition?

Thanks for the review Tony! I was originally going to use the helper, but since I only wanted start and end I figured I could get away without it :)

Anyway, I updated to use the helper. This is part of me getting transitions working for calc so I'm going to have to use the helper sooner or later :)
Comment 6 WebKit Review Bot 2012-06-24 20:16:25 PDT 
Comment on attachment 149214 [details]
Patch for landing

Clearing flags on attachment: 149214

Committed r121132: <http://trac.webkit.org/changeset/121132>
Comment 7 WebKit Review Bot 2012-06-24 20:16:29 PDT 
All reviewed patches have been landed.  Closing bug.