BitmapImage has some code duplication to ask the source for the size.
<rdar://problem/11724321>
Created attachment 148938 [details] Patch
Comment on attachment 148938 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148938&action=review > Source/WebCore/ChangeLog:21 > + * platform/graphics/BitmapImage.cpp: > + (WebCore::BitmapImage::updateSize): > + (WebCore): > + (WebCore::BitmapImage::size): > + (WebCore::BitmapImage::sizeRespectingOrientation): > + * platform/graphics/BitmapImage.h: > + (BitmapImage): I really like per-function comments, and here they would be so easy to write! > Source/WebCore/platform/graphics/BitmapImage.cpp:183 > if (m_sizeAvailable && !m_haveSize) { Might be nice to use early return since this function now is only about updating. > Source/WebCore/platform/graphics/BitmapImage.h:267 > + void updateSize() const; This could be private rather than protected.
Committed r121048: <http://trac.webkit.org/changeset/121048>