Bug 89726 - op_resolve_global should not prevent DFG inlining
Summary: op_resolve_global should not prevent DFG inlining
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-21 18:19 PDT by Filip Pizlo
Modified: 2012-06-21 18:33 PDT (History)
1 user (show)

See Also:

Attachments
the patch (11.00 KB, patch)
2012-06-21 18:22 PDT, Filip Pizlo 		barraclough: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-06-21 18:19:58 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2012-06-21 18:22:15 PDT 
Created attachment 148935 [details]
the patch
Comment 2 WebKit Review Bot 2012-06-21 18:27:30 PDT 
Attachment 148935 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/dfg/DFGOperations.h:68:  DFG_OPERATION is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2012-06-21 18:33:49 PDT 
Landed in http://trac.webkit.org/changeset/120989