Bug 89724 - Make HTMLDocumentParser::create(DocumentFragment*,Element*, FragmentScriptingPermission) private.
Summary: Make HTMLDocumentParser::create(DocumentFragment*,Element*, FragmentScripting...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-21 18:03 PDT by Kwang Yul Seo
Modified: 2012-06-21 19:50 PDT (History)
0 users

See Also:


Attachments
Patch (2.06 KB, patch)
2012-06-21 18:08 PDT, Kwang Yul Seo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2012-06-21 18:03:36 PDT
Make HTMLDocumentParser::create(DocumentFragment*,Element*, FragmentScriptingPermission) private.

It is used only by HTMLDocumentParser::parseDocumentFragment.
Comment 1 Kwang Yul Seo 2012-06-21 18:08:49 PDT
Created attachment 148932 [details]
Patch
Comment 2 Darin Adler 2012-06-21 19:28:21 PDT
Comment on attachment 148932 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148932&action=review

> Source/WebCore/html/parser/HTMLDocumentParser.h:93
> +    // Used by parseDocumentFragment

Normally we don’t write comments like this. We can learn the same thing by searching the code. And this could easily get out of date.

Also, there is a missing period here, since we use sentence style for comments.
Comment 3 Kwang Yul Seo 2012-06-21 19:50:17 PDT
(In reply to comment #2)
> (From update of attachment 148932 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=148932&action=review
> 
> > Source/WebCore/html/parser/HTMLDocumentParser.h:93
> > +    // Used by parseDocumentFragment
> 
> Normally we don’t write comments like this. We can learn the same thing by searching the code. And this could easily get out of date.
> 
> Also, there is a missing period here, since we use sentence style for comments.

I removed the comment and landed the patch manually. Thanks.

http://trac.webkit.org/changeset/120997