RESOLVED FIXED 89724
Make HTMLDocumentParser::create(DocumentFragment*,Element*, FragmentScriptingPermission) private. 
https://bugs.webkit.org/show_bug.cgi?id=89724
Summary Make HTMLDocumentParser::create(DocumentFragment*,Element*, FragmentScripting...
Kwang Yul Seo
Reported 2012-06-21 18:03:36 PDT
Make HTMLDocumentParser::create(DocumentFragment*,Element*, FragmentScriptingPermission) private. It is used only by HTMLDocumentParser::parseDocumentFragment.
Attachments
Patch (2.06 KB, patch)
2012-06-21 18:08 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1 2012-06-21 18:08:49 PDT
Created attachment 148932 [details] Patch
Darin Adler
Comment 2 2012-06-21 19:28:21 PDT
Comment on attachment 148932 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148932&action=review > Source/WebCore/html/parser/HTMLDocumentParser.h:93 > + // Used by parseDocumentFragment Normally we don’t write comments like this. We can learn the same thing by searching the code. And this could easily get out of date. Also, there is a missing period here, since we use sentence style for comments.
Kwang Yul Seo
Comment 3 2012-06-21 19:50:17 PDT
(In reply to comment #2) > (From update of attachment 148932 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=148932&action=review > > > Source/WebCore/html/parser/HTMLDocumentParser.h:93 > > + // Used by parseDocumentFragment > > Normally we don’t write comments like this. We can learn the same thing by searching the code. And this could easily get out of date. > > Also, there is a missing period here, since we use sentence style for comments. I removed the comment and landed the patch manually. Thanks. http://trac.webkit.org/changeset/120997
Note You need to log in before you can comment on or make changes to this bug.