Bug 89716 - Web Inspector: exception in TimelinePresentationModel when recording timeline
Summary: Web Inspector: exception in TimelinePresentationModel when recording timeline
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-21 17:21 PDT by Andrey Kosyakov
Modified: 2012-06-21 18:30 PDT (History)
10 users (show)

See Also:

Attachments
Patch (4.79 KB, patch)
2012-06-21 17:23 PDT, Andrey Kosyakov 		pfeldman: review+
pfeldman: commit-queue+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2012-06-21 17:21:43 PDT 
0. Open WebInspector
1. Switch to Timeline panel
2. Press record
3. Reload
4. Observe JS exception in TimelinePresentationModel.filterRecords

This is a regression introduced by r120891
Comment 1 Andrey Kosyakov 2012-06-21 17:23:11 PDT 
Created attachment 148918 [details]
Patch
Comment 2 Pavel Feldman 2012-06-21 17:50:05 PDT 
Comment on attachment 148918 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148918&action=review

> Source/WebCore/inspector/front-end/TimelinePanel.js:499
> +        var haveVisibleRecords = false;

hasVisibleRecords
Comment 3 Andrey Kosyakov 2012-06-21 18:30:37 PDT 
Committed r120988: <http://trac.webkit.org/changeset/120988>